f8d2be407d
Fixing docstring ( #5130 )
2016-12-08 11:25:18 -05:00
56120433c9
checks commit comment to make sure it doesn't exceed 60 characters ( #5155 )
...
The comment argument can be at most 60 characters per the IOS XR command
line. If a comment is > 60 characters, the module will now gracefully error
and return a well formed message.
fixes 5146
2016-12-08 11:25:18 -05:00
efca39d4d4
Remove reference to parents parameter which doesn't exist ( #5143 )
2016-12-08 11:25:18 -05:00
d12f2d2c72
Remove docs for commit which no longer exists ( #5152 )
2016-12-08 11:25:18 -05:00
9c664f424e
adds exception handling for adding an invalid condition ( #5125 )
...
This change will now handle a problem adding a condition that raises
an AddConditionError and return a well formed error to the user.
2016-12-08 11:25:18 -05:00
b4565b6667
Adding more details on DOCSTRING about how to use the module ( #5121 )
2016-12-08 11:25:18 -05:00
9707ae6490
adds exception handling for AddConditionError ( #5124 )
...
AddConditionErrors are now handled by nxos_command and a well formed error
is returned from the module
2016-12-08 11:25:17 -05:00
f5e72c6590
adds check for AddConditionError when adding conditional statements ( #5123 )
...
The Conditional instance will now raise the AddConditionError and this
change instructs eos_command to catch the error and return a nicely formed
error message
2016-12-08 11:25:17 -05:00
d4c2a13325
Improving nxos_igmp_snooping ( #5011 )
2016-12-08 11:25:17 -05:00
3c257688bc
Fixing nxos_igmp_interface ( #5010 )
2016-12-08 11:25:17 -05:00
b6c07bc9e9
Fixing nxos_hsrp ( #5009 )
...
* Fixing nxos_hsrp
* Adding space after =
2016-12-08 11:25:17 -05:00
21ae84a04e
Remove the dellosX_template module ( #5110 )
2016-12-08 11:25:17 -05:00
d58462949f
roll up of unicode fixes in junos modules ( #5113 )
...
* fixes junos_template (fixes #3962 )
* fixes junos_config
2016-12-08 11:25:17 -05:00
62bf8d0c78
Add ethernet-link-oam mapping to nxos_feature ( #4956 )
...
* Add ethernet-link-oam mapping
* Adding port-secutiry mapping
* Fixing command output format
2016-12-08 11:25:17 -05:00
67d6f2c0d6
Fixing nxos_vlan ( #5005 )
...
* Fixing nxos_vlan
* Fixing docstring
* Fixing docstring
2016-12-08 11:25:17 -05:00
43632951fe
Fixing nxos_aaa_server ( #5002 )
...
* Fixing command output formatting
* Fixing cmds
2016-12-08 11:25:17 -05:00
7f861fb9ce
Fixing nxos_acl ( #5006 )
...
* Fixing nxos_acl
* Fixing nxos_acl
2016-12-08 11:25:17 -05:00
272b20000f
Fixing nxos_acl_interface ( #5007 )
2016-12-08 11:25:17 -05:00
75c4051933
Fixing nxos_interface ( #5012 )
2016-12-08 11:25:16 -05:00
1be7ca4f70
Fxing nxos_ip_interface ( #5013 )
2016-12-08 11:25:16 -05:00
6708874f1c
Fixing nxos_mtu ( #5014 )
2016-12-08 11:25:16 -05:00
6934f11e1f
Fixing nxos_ntp ( #5015 )
2016-12-08 11:25:16 -05:00
6201a57d83
Fixing nxos_ntp_auth ( #5016 )
2016-12-08 11:25:16 -05:00
c50324fb08
Fixing nxos_ntp_options ( #5017 )
2016-12-08 11:25:16 -05:00
4b6ee73f8c
Fixing nxos_pim_interface ( #5018 )
2016-12-08 11:25:16 -05:00
5b96fb1dac
Fixing nxos_portchannel ( #5019 )
2016-12-08 11:25:16 -05:00
ebb39a0151
Fixing nxos_smu ( #5021 )
2016-12-08 11:25:16 -05:00
cda65cad18
Fixing nxos_snmp_community ( #5022 )
2016-12-08 11:25:16 -05:00
f74275fc1d
Fixing nxos_snmp_contact ( #5023 )
2016-12-08 11:25:16 -05:00
73d66e28ab
Fixing nxos_snmp_host ( #5024 )
2016-12-08 11:25:16 -05:00
7c7eee94b2
Fixing nxos_snmp_location ( #5025 )
2016-12-08 11:25:16 -05:00
19769903e6
Fixing nxos_snmp_traps ( #5026 )
2016-12-08 11:25:16 -05:00
bf59e458b1
Fixing nxos_snmp_user ( #5027 )
2016-12-08 11:25:16 -05:00
04e62346d1
Fixing nxos_udld_interface ( #5030 )
2016-12-08 11:25:16 -05:00
6bedeb28d8
Fixing nxos_switchport ( #5028 )
2016-12-08 11:25:16 -05:00
773f1703b7
Fixing nxos_udld ( #5029 )
2016-12-08 11:25:15 -05:00
d61950d48c
Fixing nxos_vpc_interface ( #5032 )
2016-12-08 11:25:15 -05:00
51c37e9f58
Fixing nxos_vrf ( #5033 )
2016-12-08 11:25:15 -05:00
8f331e01ca
Fixing nxos_vpc ( #5031 )
2016-12-08 11:25:15 -05:00
9ff6070eb8
Fixing nxos_vrf_interface ( #5034 )
2016-12-08 11:25:15 -05:00
e7286ed43c
Fixing nxos_vtp_domain ( #5036 )
2016-12-08 11:25:15 -05:00
c19e3b5924
Fixing nxos_vrrp ( #5035 )
2016-12-08 11:25:15 -05:00
f89cb1717c
Fixing nxos_vtp_password ( #5037 )
2016-12-08 11:25:15 -05:00
b897b497c1
Fixing nxos_vtp_version ( #5038 )
2016-12-08 11:25:15 -05:00
58a5ec6c51
fixes junos_command module paring of wait_for strings ( #5083 )
...
The junos_command module wasn't properly parsing strings to apply
conditionals due to the return value not being converted to json
before the results where handed to the runner.
2016-12-08 11:25:15 -05:00
9ed01d0cfd
fixes junos_template ignoring the action directive ( #5080 )
...
This updates the junos_template to properly process the action
directive when loading the configuration.
2016-12-08 11:25:15 -05:00
177dcadbc0
deprecated _template network modules: Rename in modules-core ( #5072 )
2016-12-08 11:25:14 -05:00
f7b10720ac
typo in module name ( #5062 )
2016-12-08 11:25:14 -05:00
0a85e64b4a
fixes exception raised due to KeyError ( #5068 )
...
The vyos_config module would error when looking for a key called `updates`
in module.params. There is no such key. This fixes the problem.
2016-12-08 11:25:14 -05:00
73cf85d677
catches exception if conditional cannot be parsed ( #5067 )
...
If the conditional cannot be parsed, the module will now catch the exception
and return a well formed failed message.
fixes #5060
2016-12-08 11:25:14 -05:00
da4c11241f
fixes error when 'delete ...' config command is specified but doesn't exist ( #5064 )
...
The junos_config module will generate an exception if a 'delete ...' config
command is attempted to be loaded into a device configuration. This change
will first check to see if the delete command is valid and filter it out
of the change set if it is not valid.
fixes #5040
2016-12-08 11:25:14 -05:00
aa82f48dc8
Network module code cleanup ( #5061 )
...
* Fix imports in junos_template
* Python 3 compatibility in eos_command
* Python 3 compatibility for ios_command
* Clean up issues with ios_facts
* Python 3 compatibility for ios_facts
* Import shuffle in ios_template
* Python 3 compatibility for iosxr_command
* Clean up iosxr_facts.py
* Python 3 compatibility for iosxr_facts
* Python 3 compatibility for junos_command
* Python 3 compatibility for ops_command
* Cleanup issues with ops_facts
* Python 3 compatibility for ops_facts
* Cleanup issues with ops_template
* Python 3 compatibility for vyos_command
* Cleanup issues with vyos_facts
* Python 3 compatibility for vyos_facts
2016-12-08 11:25:14 -05:00
6ae0342a0a
Fix imports in junos_template ( #5059 )
2016-12-08 11:25:14 -05:00
9b286b1775
eos_facts cleanup ( #5057 )
...
* dict.iteritems does not exist in Python 3
Now just dict.items
six.iteritems handles the change
* Addresses point 1
Unsure if this is a good idea or not.
* Addresses point 2
This shouldn't have any particular change, just marks load_comments as abstract
* Remove unused import
Addresses point 3
* Clarify invalid subset error message
Addresses point 4
2016-12-08 11:25:14 -05:00
0ef16b44ca
fixes exception being raised when show configuration command issued ( #5047 )
...
The junos_command expects commands to be returned as xml by default but
`show configuration [options]` will return text not xml. This fix
will set the output format for any command that starts with `show
configuration` to text
fixes #4628
2016-12-08 11:25:14 -05:00
a5b32fa0d1
fixes return passing output from command through jxmlease in junos_command ( #5044 )
...
The return string from the commands was not being passed through the
jxmlease library and therefore being returned as a string instead of a
json data structure. This also adds back the missing xml key in the
return that includes the raw xml string.
fixes #5001
2016-12-08 11:25:14 -05:00
4504f2d8c7
Update minimum required version and ssh rate limit ( #4995 )
2016-12-08 11:25:13 -05:00
654a38897f
fixes exception raised when nxos_facts uses nxapi transport ( #4988 )
...
This fixes a condition where an exception is raised when collecting `interface`
facts and the transport is set to nxapi in the nxos_nxapi module.
fixes ansible/ansible#17691
2016-12-08 11:25:13 -05:00
df6b7703bb
fixes default value in docstring for http ( #4985 )
...
The docstring incorrectly stated the default value for http is yes when
indeed its no. This fixes the docstring
2016-12-08 11:25:13 -05:00
88b2c7e1f6
fixes bug where setting state=absent in nxos_nxapi is not idempotent ( #4984 )
...
When setting state=absent the nxos_nxapi module would always try to remove
the configuration regardless of the current state of the device. This will
fix that problem.
This also updates the docstring to correctly reflect https as default=no
fixes #4955
depends on ansible/ansible#17728
2016-12-08 11:25:13 -05:00
f63e5d078e
Force is not a 2.2 feature
...
9b5e6bbfa1
2016-12-08 11:25:13 -05:00
b06123e986
fixes junos_config to be idempotent when confirming a commit ( #4946 )
...
The junos_config module would always return true when confirming a commit
This changes the module to now check first making the feature idempontent
2016-12-08 11:25:12 -05:00
868c298968
fixes import statements in junos_package module ( #4929 )
...
This fixes the import statement to import NetworkModule from network instead
of from junos
2016-12-08 11:25:11 -05:00
3e577f6312
fix up junos_facts import statements ( #4928 )
...
This fixes the junos_facts import statements and removes importing
NetworkModule from the junos shared module.
2016-12-08 11:25:11 -05:00
b9cb9d6345
fix import in junos_command module ( #4927 )
...
This fixes the import statements in the junos_command module to be
consistent with all junos_* modules
2016-12-08 11:25:11 -05:00
82cf70e0f3
roll up of bug fixes for junos_config module ( #4925 )
...
* fixed docstring referencing old arguments
* changed out lxml for xml library to avoid import errors
* fixed issue when trying to confirm a commit will end up a NOOP
* fixed issue for passing replace argument to load_config method
2016-12-08 11:25:11 -05:00
0acab8bd19
bug fixes in junos_netconf module ( #4924 )
...
* fixes exception thrown when sending commands to device
* fixes exception thrown when retrieving current resource instance
* fixes issue where netconf would be configured in some instances when state
was set to absent
* now returns the command string sent to the remote device
* fixes argument name to be netconf_port with alias to listens_on
2016-12-08 11:25:11 -05:00
319b2b28cb
Fix YAML syntax in NXOS documentation ( #4922 )
...
* Fix YAML syntax in NXOS documentation
Use ':' and not '=' to ensure valid YAML
in the EXAMPLES
* Correcting introduced syntax error
2016-12-08 11:25:11 -05:00
6cdcf09984
Remove duplicate keys from module docs. ( #4920 )
2016-12-08 11:25:11 -05:00
c47fd4b3e9
Add feature mappings
2016-12-08 11:25:11 -05:00
25375f1057
adds exception handling to nxos_command for FailedConditionalError
...
This adds exception handling as per ansible/ansible#17638 to the
nxos_command module.
2016-12-08 11:25:11 -05:00
a8ca526450
bug fix that now catches FailedConditionalError when specifying conditionals
...
This is related to ansible/ansible#17638 and updates the eos_command module
to catch the exception and return a santatized error.
2016-12-08 11:25:11 -05:00
90378e9168
Fix duplicate required key error
...
ansible-doc -vvvv -l show this warning:
[WARNING]: While constructing a mapping from /home/misc/checkout/git/ansible/lib/ansible/modules/core/network/junos/junos_config.py,
line 88, column 5, found a duplicate dict key (required). Using last defined value only.
2016-12-08 11:25:10 -05:00
0c94d84910
eos_eapi module allows independent configuration of protocol and port
...
The eos_eapi module would not configure the port if the protocol wasn't
configured as reported in #4905 . This changes the behavior to now allow
the port to be configured independently
fixes #4905
2016-12-08 11:25:10 -05:00
6701f038ba
Fixed docstring
2016-12-08 11:25:10 -05:00
0eb63cdeaa
Fixing nxos_portchannel
2016-12-08 11:25:10 -05:00
1ee897e988
Addressed review comments, given as part of other reviews ( #4904 )
2016-12-08 11:25:10 -05:00
a7242039ad
Updated the config module to use the new Parse method for OS6
2016-12-08 11:25:10 -05:00
8adc05051c
Added support for template module for Dell OS6 devices
2016-12-08 11:25:10 -05:00
1a8e0487ff
fixing the CI issue, the python interperter line
2016-12-08 11:25:10 -05:00
4fd0ad09b3
Updated the copyright
2016-12-08 11:25:10 -05:00
89cd8c03c0
Added support for dellos6_facts module
2016-12-08 11:25:10 -05:00
1c4efc8b2c
dnos* -> dellos* (Rename module & updated copyright) ( #4888 )
...
* Renamed the Modules from dnos* -> dellos*, updated copyright, corrected doc issues
* Removed the unwanted module import
2016-12-08 11:25:10 -05:00
989793483f
fix up eos_eapi module
...
* fixes TypeError: load_config() got an unexpected keyword argument 'session'\n"
* removes qos argument
ref #4869
2016-12-08 11:25:09 -05:00
d75c2ea475
Fix documentation fragment references. ( #4890 )
2016-12-08 11:25:09 -05:00
13e87e3a6c
Adding nxos_igmp_snooping
2016-12-08 11:25:09 -05:00
15c07334c7
Adding nxos_aaa_server_host
2016-12-08 11:25:09 -05:00
4b6a59bd13
Adding nxos_udld_interface
2016-12-08 11:25:09 -05:00
f1a96986c4
Adding 2.1 and 2.2 support to nxos_switchport
2016-12-08 11:25:09 -05:00
e669d3e889
Adding nxos_snmp_user
2016-12-08 11:25:09 -05:00
693f8e623a
Improving argument_spec
2016-12-08 11:25:09 -05:00
2f58306564
Adding nxos_pim_interface
2016-12-08 11:25:09 -05:00
48942d6e32
Fixing docstring
2016-12-08 11:25:09 -05:00
b42f6da0ce
Adding nxos_mtu
2016-12-08 11:25:09 -05:00
d8b2b0387b
Adding nxos_vtp_version
2016-12-08 11:25:09 -05:00
da8aa0dd29
Removing unused function
2016-12-08 11:25:09 -05:00
d53b52d528
Fixing module name
2016-12-08 11:25:08 -05:00
d435aca86e
Adding missing version_added
2016-12-08 11:25:08 -05:00
bf2e0ec953
Adding nxos_vtp_domain
2016-12-08 11:25:08 -05:00
b1f33ca5a0
Improved function
2016-12-08 11:25:08 -05:00
Gabriele
Peter Sprygada
John R Barker
Senthil Kumar Ganesan
Nathaniel Case
Josh Lothian
Matt Clay
Peter Sprygada
Michael Scherer