6c439a4882
user: Cast all arguments to string before passing to run_command ( #4398 )
...
Fixes #4397
2016-12-08 11:24:50 -05:00
16ccde49ad
remove X bit
2016-12-08 11:24:49 -05:00
fb255b3607
Improve hostname module to support systemd in more generic way ( #4382 )
...
Now that there is general purpose `Fact` helper to detect if systemd
is active, we would be able to rely on that to apply SystemdStrategy.
Detecting presence of systemd at runtime would be more reliable than
distribution version based heuristics. (e.g., Debian, Ubuntu allows
user to change the default init system, Gentoo allows switching as
well, and so on).
2016-12-08 11:24:49 -05:00
ab3a87cc1a
improved logic when dealing with init scripts
2016-12-08 11:24:49 -05:00
3c89a21e0c
fixes corner case for systemd services
...
when both unit file and sysv init script exist
Thanks to @olfway for fix.
fixes #3764
2016-12-08 11:24:49 -05:00
3a44d60fbc
Fixes #3791 cron always returning changed state for multiline jobs ( #4285 )
...
Strip only newlines and carriage returns. Instead of stripping ALL whitespace, which may have unintended side effects
2016-12-08 11:24:49 -05:00
766413e79d
Allow cron to target remote user ( #4270 )
2016-12-08 11:24:49 -05:00
cd3c454917
Add a example with a non service unit ( #4355 )
...
Since the documentation focus mostly on service
units, a explicit example may help people realizing
it can be used for socket and timer too.
2016-12-08 11:24:48 -05:00
3c2110215c
Do not hardcode default ssh key size for RSA ( #4074 )
...
By default, ssh-keygen will pick a suitable default for ssh keys
for all type of keys. By hardocing the number of bits to the
RSA default, we make life harder for people picking Elliptic
Curve keys, so this commit make ssh-keygen use its own default
unless specificed otherwise by the playbook
2016-12-08 11:24:47 -05:00
e526b2ad3d
system/service.py: fix false-positive service enablement on FreeBSD. ( #4283 )
...
sysrc(8) does not exit with non-zero status when encountering a
permission error.
By using service(8) `service <name> enabled`, we now check the actual
semantics expressed through calling sysrc(8), i.e. we check if the
service enablement worked from the rc(8) system's perspective.
Note that in case service(8) detects the wrong value is still set,
we still output the sysrc(8) output in the fail_json() call:
the user can derive the exact reason of failure from sysrc(8) output.
2016-12-08 11:24:46 -05:00
f10413b919
better authorized_keys documentation ( #3739 )
2016-12-08 11:24:43 -05:00
72eaf0281a
updated checkmode for update-rc.d
...
fixes #4146
2016-12-08 11:24:43 -05:00
d5b35eb8db
add gather_timeout parameter ( #4093 )
2016-12-08 11:24:42 -05:00
e25cb4df77
service module: use sysrc on FreeBSD ( #4042 )
...
* service module: use sysrc on FreeBSD
sysrc(8) is the designated userland program to edit rc files on FreeBSD.
It first appeared in FreeBSD 9.2, hence is available on all supported
versions of FreeBSD.
Side effect: fixes #2664
* Incorporate changes suggested by bcoca.
- Use `get_bin_path` to find sysrc binary.
- Only use sysrc when available (support for legacy versions of FreeBSD)
2016-12-08 11:24:41 -05:00
186db40864
make daemon reload first thing always run
...
otherwise service detection can fail before we run it which might
be required to actually detect the service.
2016-12-08 11:24:41 -05:00
20d8103b53
Showing some of the sysctl settings in proper yaml format per Ansible documentation ( #4073 )
2016-12-08 11:24:41 -05:00
6d6b8a1823
Fixes #1715 Allow authorized_module accept multi. ( #3573 )
...
This will allow the authorized_module to accept options that can be
passed multiple times into ssh options. For instance permitopen.
2016-12-08 11:24:38 -05:00
0bd32c3465
Clarify behaviour when state=present and no name is given ( #3904 )
2016-12-08 11:24:36 -05:00
03515fc26c
Fixed Typo in Examples of systemd module ( #3870 )
2016-12-08 11:24:35 -05:00
03f06ca2e8
fixed issue with multiline output from systemd
...
fixes #3868
2016-12-08 11:24:35 -05:00
cffe358260
fixed enabled state
2016-12-08 11:24:33 -05:00
df1b03d0c6
fixed reported state
2016-12-08 11:24:33 -05:00
6f5dfcf1bd
Added statement about escaping characters in chron tasks ( #3770 )
2016-12-08 11:24:32 -05:00
13d7a61160
Fix crontab argument order for writing ( #3750 )
...
Currently, when writing user's crontab, ansible calls
crontab <file> -u <user>
This is incorrect according to crontab(1) on both FreeBSD and Linux,
which suggest that file argument should be the last.
At least on FreeBSD, this leads to incorrect cron module bahavior which
writes to root's crontab instead of users's
2016-12-08 11:24:31 -05:00
01819bbc9d
fixed enabled reporting
2016-12-08 11:24:31 -05:00
38d71b9eef
fixed typo
2016-12-08 11:24:31 -05:00
472d5c11ef
added state in results for backwards compat
2016-12-08 11:24:31 -05:00
8085678dc8
first draft systemd service plugin ( #3660 )
...
* first draft systemd service plugin
* now systemd status handles multiline values
2016-12-08 11:24:31 -05:00
d34c5dfd69
Added one extra example in the authorized_key module. ( #3637 )
2016-12-08 11:24:30 -05:00
8c2b333a73
Proposed fix to not require src and fstype arguments for mount. Issue #1259 . ( #1357 )
2016-12-08 11:24:30 -05:00
c952753735
Do not ignore the primary group if modifying the list of secondary groups. ( #3585 )
...
Fixes #1118
2016-12-08 11:24:30 -05:00
cca89ef489
Port seboolean to py3/py2.4 syntax ( #3679 )
2016-12-08 11:24:29 -05:00
c793571bc3
Port mount to python3 and python 2.4 compatible syntax ( #3678 )
2016-12-08 11:24:29 -05:00
fd61e81764
Port authorized_keys to a syntax compatible with python3 and 2.4 ( #3677 )
2016-12-08 11:24:28 -05:00
907b3fb667
Port hostname to a py24 and py3 compatible syntax ( #3676 )
2016-12-08 11:24:28 -05:00
e02f401225
Port sysctl to a py3 and py24 compatible syntax ( #3675 )
2016-12-08 11:24:28 -05:00
f0fd1109dd
Port cron to a py3 and py24 compatible syntax ( #3674 )
2016-12-08 11:24:28 -05:00
f2212dc41a
Port user module to python3 and 2.4 compatible syntax ( #3673 )
2016-12-08 11:24:28 -05:00
93fe022aa4
Port to dual python2/python3 compat
2016-12-08 11:24:27 -05:00
e10b7e1773
Port ping to dual python3/2 compat.
2016-12-08 11:24:27 -05:00
bc39f8c42e
Revert "remove checking of stderr for insserv ( #1846 )"
...
This reverts commit 2ee6e4cf668a9bba77c3bb019d473f3614563838.
2016-12-08 11:24:26 -05:00
ca8bf6ab4c
remove checking of stderr for insserv ( #1846 )
...
stderr of insserv can also contain warnings which can be ignored. checking rc only is more accurate.
fixes #1502
2016-12-08 11:24:26 -05:00
8a4257d297
removed incorrect defaults from docs
2016-12-08 11:24:23 -05:00
9284c80039
Escape spaces, backslashes when create new entry in fstab ( #3193 )
...
Supplement to PR #1454 and issue #530 .
Fixes #3192 .
Fixes #1861 (introduced by PR #1454 ).
Signed-off-by: Konstantin Gribov <grossws@gmail.com>
2016-12-08 11:24:23 -05:00
582a5bccc8
Make FreeBSD subclass respect the sleep option.
2016-12-08 11:24:20 -05:00
5b32a299a5
Change home and ssh_key_file to 'path' in user module
2016-12-08 11:24:20 -05:00
15ae8c8e0b
Fix mount's handling of passno
2016-12-08 11:24:17 -05:00
ee06cd27b2
use custom ismount function in mount module ( #2737 )
...
* based on cpython os.path.ismount
* includes patch from http://bugs.python.org/issue2466
* fixes #2186
* when the upstream bug is fixed this should be removed/rewritten
* use ismount from module_utils
2016-12-08 11:24:17 -05:00
4c40886814
Remove the ignore_ohai and ignore_facter parameters as the functionality was merged into gather_subset
2016-12-08 11:24:12 -05:00
368cf59e4b
Add diff and check mode to cron module
...
supports not writing backup file in check mode and new environment
vars.
2016-12-08 11:24:12 -05:00
jctanner
Brian Coca
Indrajit Raychaudhuri
Evan Kaufman
BradLook
Michael Scherer
Christian Schwarz
Marcos Diez
Michael LoSapio
Allen Sanabria
Thomas Quinot
Robin Naundorf
Erik Nadel
Dmitry Marakasov
Brian Coca
Ken Mitchell
Toshio Kuratomi
TheSameCH
Konstantin Gribov
Guido Falsi
Michael Scherer
Joshua Kugler
Robin Roth
Tobias Wolf
