* fix the variable collision issue
* make output format in such a way that it returns a dict
* changes
* changes
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* revert back changes
* changes
* changes
* fix the error
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* add dict construct
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* replace_keys: Add complex integration tests.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Changelog
* Add fail_msg to first test.
* some changes
* adds correct integration tests :D
* delete the inventory file
* use fqcn format
* delete the unwanted file
* fix integration test
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* update
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ruchi Pakhle <ruchipakhle@gmail.com>
* fix: netaddr fallback to is_private when is_global is not available
* fix: adjust fallback logic to edge cases
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* fix: address pylint errors
* fix: comment spacing in test task broken by prettier
* changelog update
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: Marcin Lewandowski <mlewandowski@pl.ibm.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ruchi Pakhle <ruchipakhle@gmail.com>
* Enhance fact_diff to show common lines
* Add integration and unit tests
* Fix sanity
---------
Co-authored-by: Ashwini Mhatre <amhatre@amhatre-thinkpadt14sgen2i.pnq.csb>
* Fix bug in ipv4_hex filter.
* Fix issue in ipv4_hex
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update tests/integration/targets/utils_ipaddr_filter/tasks/ip4_hex.yaml
Co-authored-by: Sagar Paul <sagpaul@redhat.com>
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sagar Paul <sagpaul@redhat.com>
* Update jsonschema validator
Update jsonschema validator to support newer drafts. It now supports
drafts 2019-09 and 2020-12.
The logic for choosing the jsonschema validator class has changed so
that the following enhancements are available:
- When no draft is explicitly specified we now use use the validator
draft that is specified in the "$schema" field of the criteria. This
is done by the jsonschema module by default and should support
possible future drafts without any changes to this code.
- Optionally allow to disable format checks in the code. As format
checks are not required by the spec there might be situations where
people want to disable them.
* Update requirements.txt
* Skip all tests which dependas on jsonschema 4.5
* jsonschema: Refactor code to support python 3.6
* Fix jsonschema requirements for python<3.7
* jsonschema: Update code for compatibility
* Better documentation and error handling for missing schema specifications
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ashwini Mhatre <amhatre@redhat.com>
Co-authored-by: ashwini-mhatre <mashu97@gmail.com>
* Add Unit Tests To Capture Failures From 'subnet' Generator
The netaddr library returns a generator for the 'subnet' call. This works great until you use larger networks. While it is uncommon to encounter it in IPv4 usage it is trivial to hit it in IPv6.
* Switch To Calculating Networking Information Directly For Performance
This replaces the inefficient generator for 'subnet' and uses math to determine the result directly. Since a list is not returned directly to the client in the implemented cases this works great and is fast.
A further optimization at least on the logic of this might be to break the different cases implemented by the filter out into unique functions. I did not do this yet because I wanted to get feedback on this direction.
* Changelog Fragment For PR / Bugfix
Adding changelog fragment that references source issue.
* Dropping Python 3.7 Bypass Removes Need For 'sys' Module
A test for ipsubnet was bypassed under 3.7 because of an inconsistent return value w/3.6 and 2.7. I removed the bypass and changed the behavior of the filter to raise an AnsibleFilterError in all versions of Python.
* Add A Pair of Integration Tests
These demonstrate the issue with the current implementation and would normally stall out while building the list of possible subnets from the generator.
* Address Changelog Feedback
I kept the performance item as a bugfix but bumped the typing to a minor change.
* Add 'netaddr' To Integration Test 'requirements.txt'
* The `ansible-test integration --docker` requires this line in requirements.txt to pass the 'netaddr' related tests
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Replace str -> to_text
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kate Case <this.is@katherineca.se>
Add plugin Reduce_on_network
SUMMARY
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
Add next nth usable filter plugin
SUMMARY
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
Reviewed-by: None <None>
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Add ipsubnet filter plugin
SUMMARY
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: None <None>
Add IPV6 filter plugin
SUMMARY
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: None <None>
Fix issue of not running tests in network ee for some targets
SUMMARY
fix issue of some integration targets was not running in network ee.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Matt Martz <matt@sivel.net>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: None <None>
Update validate to use 2.11 ArgumentSpecValidator if available
SUMMARY
fixes: #85
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Bradley A. Thornton <bthornto@redhat.com>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: None <None>
Add support for the validation of formats to the json schema validator
SUMMARY
fixes: #81
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Ganesh Nalawade <None>
Ruchi Pakhle
Vladimir Botka
Marcin Lewandowski
rizlas
Ashwini Mhatre
Sebastian Wiesinger
Tim Way
Bradley A. Thornton
KB-perByte
pre-commit-ci[bot]
Nathaniel Case
Rohit Thakur
stoned