Commit Graph

56 Commits (3f98e8ae7a57ad09b7c8e9792dd3075c34cb7ac6)

Author SHA1 Message Date
KB-perByte 02779ae85a
UTs added 2022-04-05 12:23:31 +05:30
KB-perByte 141c175cff
sanity fixex updated 2022-04-04 17:58:09 +05:30
Ashwini Mhatre 0716010fe3
Fix bugs in Ipaddr filters (#149)
Fix bugs in Ipaddr filters

SUMMARY

ipaddr - Fix input validation issues in ipaddr,ipv4,ipv6,ipwrap filters.
ipaddr - Add valid network for link-local
fixes: #148
fixes: ansible-collections/ansible.netcommon#375
fixes: ansible-collections/ansible.netcommon#350

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
2022-03-04 11:43:59 +00:00
Ashwini Mhatre 9f510450f8
Improve ut coverage (#145)
Improve ut coverage

SUMMARY

Add more testcases for ipaddr filter

ISSUE TYPE

COMPONENT NAME

ipaddr.py
ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
2022-03-01 05:06:47 +00:00
Tim Way a14a9337c6
Add 'netaddr' To 'requirements.txt' For Unit Tests (#143)
Add 'netaddr' To 'requirements.txt' For Unit Tests

This enables 'ansible-test --docker' and 'ansible-test --venv' to be able to leverage 'netaddr' and pass tests

SUMMARY

This adds the 'netaddr' python module to the requirements specific to unit tests. This allows 'ansible-test' to work for '--docker' and '--venv' without manual intervention.
I also re-ordered the current list to be alphabetical.

Fixes #142
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

Unit tests in ansible.utils for ipsubnet
ADDITIONAL INFORMATION



git clone https://github.com/ansible-collections/ansible.utils.git
cd ansible.utils
ansible-galaxy collection build .
ansible-galaxy collection install -p . ansible-utils-\*.tar.gz
ansible-test units --docker base tests/unit/plugins/filter/test_ipsubnet.py --requirements --verbose

Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
2022-02-25 07:32:23 +00:00
Nathaniel Case ad9d3e1399
New validate sub-plugin "config" (#112)
New validate sub-plugin "config"

SUMMARY


Implement ansible-collections/ansible.network#15 as a validate sub-plugin.
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

validate

Reviewed-by: Ganesh Nalawade <None>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: None <None>
2022-01-28 00:02:36 +00:00
Sagar Paul 624bc76e26
Recursive filter plugins remove_keys | replace_keys | keep_keys (#110)
Recursive filter plugins remove_keys | replace_keys | keep_keys

SUMMARY

New plugins

remove_keys
replace_keys
keep_keys


ISSUE TYPE


New Module Pull Request

COMPONENT NAME


remove_keys
replace_keys
keep_keys

ADDITIONAL INFORMATION

Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-27 06:52:38 +00:00
Ashwini Mhatre ea54e97359
Add hwaddr, macaddr, slaac filter plugin (#129)
Add hwaddr, macaddr, slaac filter plugin

SUMMARY

Added hwaddr, macaddr, slaac filter plugin

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: None <None>
2022-01-24 21:43:18 +00:00
Ashwini Mhatre 4488b79b04
Add ipaddr Filter plugin (#115)
Add ipaddr Filter plugin

SUMMARY

depend-on: #113

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: None <None>
2022-01-24 11:15:16 +00:00
Ashwini Mhatre cfc7965400
Add ipwrap filter plugin (#118)
Add ipwrap filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Priyam Sahoo <None>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: None <None>
2022-01-22 11:27:27 +00:00
Ashwini Mhatre 2aa677777e
Add network_in_usable filter plugin (#126)
Add network_in_usable filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
Reviewed-by: Priyam Sahoo <None>
2022-01-21 20:12:17 +00:00
Ashwini Mhatre 3cb7ea10ca
Add previous_nth_usable filter plugin (#124)
Add previous_nth_usable filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-21 18:04:36 +00:00
Ashwini Mhatre 315200166f
Add plugin Reduce_on_network (#127)
Add plugin Reduce_on_network

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-21 10:34:01 +00:00
Ashwini Mhatre 234b0a51cf
Add network_in_network filter plugin (#125)
Add network_in_network filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-20 19:31:40 +00:00
Ashwini Mhatre 1d697455b6
Add next nth usable filter plugin (#123)
Add next nth usable filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
Reviewed-by: None <None>
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
2022-01-20 17:30:14 +00:00
Ashwini Mhatre 80b7015fe8
Add ipsubnet filter plugin (#122)
Add ipsubnet filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: None <None>
2022-01-20 15:03:54 +00:00
Ashwini Mhatre c04c648b7a
Add IPV6 filter plugin (#121)
Add IPV6 filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: None <None>
2022-01-20 13:10:31 +00:00
Ashwini Mhatre 79b28faaaa
Add ipv4_hex filter plugin (#119)
Add ipv4_hex filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Priyam Sahoo <None>
Reviewed-by: None <None>
2022-01-20 11:48:12 +00:00
Ashwini Mhatre 458547c2b6
Add Ipmath filter plugin (#117)
Add Ipmath filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: None <None>
2022-01-20 09:49:15 +00:00
Ashwini Mhatre 22234f2963
Add cidr_merge filter plugin (#113)
Add cidr_merge filter plugin

SUMMARY

Move ipaddr plugins from netcommon to utils:
cidr_merge filter plugin

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-20 08:02:49 +00:00
Ashwini Mhatre 7a7ad7e811
Add Nthhost filter plugin (#128)
Add Nthhost filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-19 19:10:50 +00:00
Ashwini Mhatre 02f2c62386
Add ipv4 plugin (#120)
Add IPV4 filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Priyam Sahoo <None>
Reviewed-by: None <None>
2022-01-17 11:41:11 +00:00
Rohit Thakur 2f071599d0
resource_list_compare filter plugin added (#89)
resource_list_compare filter plugin added

Signed-off-by: Rohit Thakur rohitthakur2590@outlook.com
SUMMARY

resolves: #88

Test Coverage
plugins/filter/param_list_compare.py	 	95%
tests/unit/plugins/filter/test_param_list_compare.py	 	100%
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Ganesh Nalawade <None>
Reviewed-by: Bradley A. Thornton <bthornto@redhat.com>
Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
Reviewed-by: None <None>
2021-08-12 05:15:44 +00:00
Ashwini Mhatre 61a826c997
Update validate to use 2.11 ArgumentSpecValidator if available (#86)
Update validate to use 2.11 ArgumentSpecValidator if available

SUMMARY

fixes: #85

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bradley A. Thornton <bthornto@redhat.com>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: None <None>
2021-08-03 08:04:33 +00:00
Ashwini Mhatre 45eb99fb94
Add support for the validation of formats to the json schema validator (#83)
Add support for the validation of formats to the json schema validator

SUMMARY

fixes: #81

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Ganesh Nalawade <None>
2021-06-28 13:27:51 +00:00
stoned 0a2e083c9b
Make to_paths handles empty list and mapping (#58)
Make to_paths handles empty list and mapping

Reviewed-by: https://github.com/apps/ansible-zuul
2021-06-17 07:26:13 +00:00
Priyam Sahoo 1b76548d9d
Added 'usable_range' filter plugin (#77)
Added 'usable_range' filter plugin

Reviewed-by: https://github.com/apps/ansible-zuul
2021-06-03 07:17:07 +00:00
Ashwini Mhatre 454e2ca935
Improve coverage for from_xml and to_xml (#76)
Improve coverage for from_xml and to_xml

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-31 10:54:07 +00:00
Priyam Sahoo 2636312822
Added 'resolvable' test plugin (#74)
Added 'resolvable' test plugin

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-14 20:24:11 +00:00
Priyam Sahoo 86923a5f2d
Added 'subnet_of', 'supernet_of', 'unspecified' IP test plugins (#73)
Added 'subnet_of', 'supernet_of', 'unspecified' IP test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-14 14:01:41 +00:00
Priyam Sahoo e57f25a510
Added 'private', 'public', 'reserved' test plugins (#72)
Added 'private', 'public', 'reserved' test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-12 15:42:19 +00:00
Priyam Sahoo 0c315db82e
Added 'loopback', 'mac', and 'multicast' test plugins (#71)
Added 'loopback', 'mac', and 'multicast' test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-11 16:23:05 +00:00
Priyam Sahoo 842549a236
Added ipv6 test plugins (#70)
Added ipv6 test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-10 18:19:24 +00:00
Priyam Sahoo e92cc6e78d
Added ipv4 specefic test plugins (#69)
Added ipv4 specefic test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-07 18:30:00 +00:00
Priyam Sahoo 1c9866e8d8
Added 'ip', 'ip_address' test plugins (#68)
Added 'ip', 'ip_address' test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-06 11:12:27 +00:00
Priyam Sahoo c09bbacdbc
Added 'in_any_network', 'in_network', 'in_one_network' test plugins (#66)
Added 'in_any_network', 'in_network', 'in_one_network' test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-03 14:22:35 +00:00
stoned 7458f4e44a
Add missing test requirements (#57)
Add missing test requirements

Reviewed-by: https://github.com/apps/ansible-zuul
2021-04-27 08:26:47 +00:00
Ashwini Mhatre 43e77543d9
Add to_xml and from_xml filter plugin (#56)
Add to_xml and from_xml filter plugin

Reviewed-by: https://github.com/apps/ansible-zuul
2021-04-09 13:20:17 +00:00
Nilashish Chakraborty 1d28b7a1d7
Fix index_of integration test (#61)
Fix index_of integration test

Reviewed-by: https://github.com/apps/ansible-zuul
2021-03-30 11:57:39 +00:00
Ganesh Nalawade f5dd4b80e7
Fix jsonschma input data validation (#50)
Fix jsonschma input data validation

Reviewed-by: https://github.com/apps/ansible-zuul
2021-03-15 09:00:44 +00:00
Ganesh Nalawade 4c531bb418
Fix cli_parse template_path read error (#51)
Fix cli_parse template_path read error

Reviewed-by: https://github.com/apps/ansible-zuul
2021-03-10 03:46:23 +00:00
Ganesh Nalawade 8aa8916e01
Move sub plugins under plugins/sub_plugins directory and common code in plugin_utils (#33)
Move sub plugins under plugins/sub_plugins directory and common code in plugin_utils

Reviewed-by: https://github.com/apps/ansible-zuul
2021-01-29 06:05:24 +00:00
Ganesh Nalawade dccab0d9f1
Ansible 3.0.0 collection inclusion releated changes (#32)
Ansible 3.0.0 collection inclusion releated changes

Reviewed-by: https://github.com/apps/ansible-zuul
2021-01-25 11:27:04 +00:00
Ganesh Nalawade a22cbd97b2
Add cli_parse module and plugins (#28)
Add cli_parse module and plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2020-12-02 13:57:56 +00:00
Bradley A. Thornton 3d762f7800
CI cleanup (#23)
CI cleanup

Reviewed-by: https://github.com/apps/ansible-zuul
2020-10-30 21:36:30 +00:00
Ganesh Nalawade 1807ee7c7b
Add validate action/lookup/filter/test plugin (#13)
* Initial commit

* Add validate lookup/filter/test plugin

*  Update agrspec validation logic
*  Add validate lookup/filter/test plugin

* minor updates

* remve unwanted code

* doc update

* update jsonschema validator plugin

* Add validate sub-plugin configurable option

* fix black failures

* fix ansible-test validate module issue

* fix santiy issues

* more santiy fixes

* remove GA black formatting

* add black

* fix black formatting

* fix black issues

* Add integration test and fix review comments

* add jsonschema to requirments

* fix ci issues

* update GA to install requirments

* fix GA to install requirments

* move ValidateBase to base file

* fix library not found issue in CI

* add unit test
2020-10-28 13:39:20 -07:00
Bradley A. Thornton c20ba34c7d
Fact diff (#15)
* Add fact_diff action

* Formatting

* Update docs

* Add skip_lines

* Update docs

* black

* bug fix

* Add units for fact_diff

* Initial changes to support plugin architecture

* Restructure docstring

* Integration test fix

* Wrap diff plugin with try/except

* Fix integration test

* Restructure code to allow for plugin failure test

* Examples, docs

* Fix debug statement

* Update examples

* Minor doc updates

* Minor doc updates

* Minor doc updates

* Add change log

Co-authored-by: cidrblock <brad@thethorntons.net>
2020-10-23 04:48:16 -07:00
Bradley A. Thornton 188463f7be
update_fact plugin + units (#10)
* update_fact plugin + units

* Update README, add doc

* Add some update_fact integration tests

* Add missing test for not (index_of)

* Update fact doc updates

* Update rst from doc

* Examples as yaml

* Some developer notes (#11)

Co-authored-by: cidrblock <brad@thethorntons.net>

* Updated self._task.args from updated_data provided back from aav

* Argspec default fix (#12)

* Return data updated with default values from aav.validate()

* Update aav docs

Co-authored-by: cidrblock <brad@thethorntons.net>

* update_fact plugin + units

* Update README, add doc

* Add some update_fact integration tests

* Add missing test for not (index_of)

* Update fact doc updates

* Update rst from doc

* Examples as yaml

* Updated self._task.args from updated_data provided back from aav

* recheck

* Plugin cleanup (#14)

* WIP

* Add argspec validation to plugins, restructure tests

* Update docs

* Pre PY3.8 compat changes

* Run black to fix quotes

* Seems the order of missing keys varies between 2.9 and 2.10

* More error ordering issues fixed during argspec validation

* More black, wrong version

Co-authored-by: cidrblock <brad@thethorntons.net>

* update_fact plugin + units

* Update README, add doc

* Add some update_fact integration tests

* Update fact doc updates

* Update rst from doc

* Examples as yaml

* Updated self._task.args from updated_data provided back from aav

* recheck

Co-authored-by: cidrblock <brad@thethorntons.net>
2020-10-20 12:32:35 -07:00
Bradley A. Thornton bcddde229d
Plugin cleanup (#14)
* WIP

* Add argspec validation to plugins, restructure tests

* Update docs

* Pre PY3.8 compat changes

* Run black to fix quotes

* Seems the order of missing keys varies between 2.9 and 2.10

* More error ordering issues fixed during argspec validation

* More black, wrong version

Co-authored-by: cidrblock <brad@thethorntons.net>
2020-10-20 12:14:23 -07:00
Bradley A. Thornton 024daa9dfe
Argspec default fix (#12)
* Return data updated with default values from aav.validate()

* Update aav docs

Co-authored-by: cidrblock <brad@thethorntons.net>
2020-10-20 07:50:08 -07:00