Commit Graph

63 Commits (c2af5541ade431689afc80a4d5b4c754e24af135)

Author SHA1 Message Date
Sebastian Wiesinger c2231a6b20
Update jsonschema validator (#226)
* Update jsonschema validator

Update jsonschema validator to support newer drafts. It now supports
drafts 2019-09 and 2020-12.

The logic for choosing the jsonschema validator class has changed so
that the following enhancements are available:

- When no draft is explicitly specified we now use use the validator
  draft that is specified in the "$schema" field of the criteria. This
  is done by the jsonschema module by default and should support
  possible future drafts without any changes to this code.

- Optionally allow to disable format checks in the code. As format
  checks are not required by the spec there might be situations where
  people want to disable them.

* Update requirements.txt

* Skip all tests which dependas on jsonschema 4.5

* jsonschema: Refactor code to support python 3.6

* Fix jsonschema requirements for python<3.7

* jsonschema: Update code for compatibility

* Better documentation and error handling for missing schema specifications

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ashwini Mhatre <amhatre@redhat.com>
Co-authored-by: ashwini-mhatre <mashu97@gmail.com>
2023-04-05 11:01:12 -04:00
Ashwini Mhatre fca1229097
Added support to disable xml declartion with full_document flag (#237) 2022-12-28 19:47:34 +05:30
Ashwini Mhatre 09362a2d98
Fix ansible lint issues (#235)
* Fix ansible-lint issues
2022-12-28 12:37:35 +05:30
Ashwini Mhatre e5591508fa
Fix Ansible lint FQCN error (#227)
* Fix set_fact ansible-lint

* Fix assert ansible-lint

* Fix find ansible-lint

* Fix debug ansible-lint

* Add FQCN
2022-11-29 19:28:12 +05:30
Ashwini Mhatre baba9ca7ea
Accept int input for ipaddr ipv4 and ipv6 filters (#224)
* Accept int input for ipaddr ipv4 and ipv6 filters

* Fix fragment

* Fix tests
2022-11-21 15:18:35 +05:30
Tim Way 57c5cd4336
Switch To Calculating Networking Information Directly For Performance (#146)
* Add Unit Tests To Capture Failures From 'subnet' Generator

The netaddr library returns a generator for the 'subnet' call. This works great until you use larger networks. While it is uncommon to encounter it in IPv4 usage it is trivial to hit it in IPv6.

* Switch To Calculating Networking Information Directly For Performance

This replaces the inefficient generator for 'subnet' and uses math to determine the result directly. Since a list is not returned directly to the client in the implemented cases this works great and is fast.

A further optimization at least on the logic of this might be to break the different cases implemented by the filter out into unique functions. I did not do this yet because I wanted to get feedback on this direction.

* Changelog Fragment For PR / Bugfix

Adding changelog fragment that references source issue.

* Dropping Python 3.7 Bypass Removes Need For 'sys' Module

A test for ipsubnet was bypassed under 3.7 because of an inconsistent return value w/3.6 and 2.7. I removed the bypass and changed the behavior of the filter to raise an AnsibleFilterError in all versions of Python.

* Add A Pair of Integration Tests

These demonstrate the issue with the current implementation and would normally stall out while building the list of possible subnets from the generator.

* Address Changelog Feedback

I kept the performance item as a bugfix but bumped the typing to a minor change.

* Add 'netaddr' To Integration Test 'requirements.txt'

* The `ansible-test integration --docker` requires this line in requirements.txt to pass the 'netaddr' related tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Replace str -> to_text

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kate Case <this.is@katherineca.se>
2022-08-31 12:09:35 -04:00
Bradley A. Thornton 2541cb3f6a
Add isort, increase black line length (#189) 2022-05-26 13:18:57 -04:00
Bradley A. Thornton 4fe771a95c
Enable prettier via pre-commit (#188) 2022-05-26 10:02:52 -04:00
Bradley A. Thornton 50201a1ad9
Enable integration tests with Github action (#180) 2022-05-18 11:06:59 -07:00
KB-perByte ceb7db1cd3
del extra 2022-04-11 16:15:08 +05:30
KB-perByte ca31a4e474
update docs 2022-04-11 16:13:46 +05:30
KB-perByte 595c9ee38f
review pt 1 2022-04-08 23:31:45 +05:30
Bradley A. Thornton 1c4d7faf83
Merge branch 'main' into consolidate 2022-04-07 13:20:12 -07:00
pre-commit-ci[bot] c4ad14f305 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2022-04-07 03:28:27 -07:00
KB-perByte e7d50b8ce6
fix intergration tests 2022-04-06 13:48:47 +05:30
KB-perByte 3f98e8ae7a
sanity and tox fixed 2022-04-05 15:44:37 +05:30
KB-perByte 234b503842
update intg tests and changelog 2022-04-05 13:47:16 +05:30
Ashwini Mhatre 0716010fe3
Fix bugs in Ipaddr filters (#149)
Fix bugs in Ipaddr filters

SUMMARY

ipaddr - Fix input validation issues in ipaddr,ipv4,ipv6,ipwrap filters.
ipaddr - Add valid network for link-local
fixes: #148
fixes: ansible-collections/ansible.netcommon#375
fixes: ansible-collections/ansible.netcommon#350

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
2022-03-04 11:43:59 +00:00
Nathaniel Case ad9d3e1399
New validate sub-plugin "config" (#112)
New validate sub-plugin "config"

SUMMARY


Implement ansible-collections/ansible.network#15 as a validate sub-plugin.
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

validate

Reviewed-by: Ganesh Nalawade <None>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: None <None>
2022-01-28 00:02:36 +00:00
Sagar Paul 624bc76e26
Recursive filter plugins remove_keys | replace_keys | keep_keys (#110)
Recursive filter plugins remove_keys | replace_keys | keep_keys

SUMMARY

New plugins

remove_keys
replace_keys
keep_keys


ISSUE TYPE


New Module Pull Request

COMPONENT NAME


remove_keys
replace_keys
keep_keys

ADDITIONAL INFORMATION

Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-27 06:52:38 +00:00
Ashwini Mhatre ea54e97359
Add hwaddr, macaddr, slaac filter plugin (#129)
Add hwaddr, macaddr, slaac filter plugin

SUMMARY

Added hwaddr, macaddr, slaac filter plugin

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: None <None>
2022-01-24 21:43:18 +00:00
Ashwini Mhatre 4488b79b04
Add ipaddr Filter plugin (#115)
Add ipaddr Filter plugin

SUMMARY

depend-on: #113

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: None <None>
2022-01-24 11:15:16 +00:00
Ashwini Mhatre cfc7965400
Add ipwrap filter plugin (#118)
Add ipwrap filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Priyam Sahoo <None>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: None <None>
2022-01-22 11:27:27 +00:00
Ashwini Mhatre 2aa677777e
Add network_in_usable filter plugin (#126)
Add network_in_usable filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
Reviewed-by: Priyam Sahoo <None>
2022-01-21 20:12:17 +00:00
Ashwini Mhatre 3cb7ea10ca
Add previous_nth_usable filter plugin (#124)
Add previous_nth_usable filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-21 18:04:36 +00:00
Ashwini Mhatre 315200166f
Add plugin Reduce_on_network (#127)
Add plugin Reduce_on_network

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-21 10:34:01 +00:00
Ashwini Mhatre 234b0a51cf
Add network_in_network filter plugin (#125)
Add network_in_network filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-20 19:31:40 +00:00
Ashwini Mhatre 1d697455b6
Add next nth usable filter plugin (#123)
Add next nth usable filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
Reviewed-by: None <None>
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
2022-01-20 17:30:14 +00:00
Ashwini Mhatre 80b7015fe8
Add ipsubnet filter plugin (#122)
Add ipsubnet filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: None <None>
2022-01-20 15:03:54 +00:00
Ashwini Mhatre c04c648b7a
Add IPV6 filter plugin (#121)
Add IPV6 filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: None <None>
2022-01-20 13:10:31 +00:00
Ashwini Mhatre 79b28faaaa
Add ipv4_hex filter plugin (#119)
Add ipv4_hex filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Priyam Sahoo <None>
Reviewed-by: None <None>
2022-01-20 11:48:12 +00:00
Ashwini Mhatre 458547c2b6
Add Ipmath filter plugin (#117)
Add Ipmath filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: None <None>
2022-01-20 09:49:15 +00:00
Ashwini Mhatre 22234f2963
Add cidr_merge filter plugin (#113)
Add cidr_merge filter plugin

SUMMARY

Move ipaddr plugins from netcommon to utils:
cidr_merge filter plugin

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-20 08:02:49 +00:00
Ashwini Mhatre 7a7ad7e811
Add Nthhost filter plugin (#128)
Add Nthhost filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
2022-01-19 19:10:50 +00:00
Ashwini Mhatre 02f2c62386
Add ipv4 plugin (#120)
Add IPV4 filter plugin

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: Priyam Sahoo <None>
Reviewed-by: None <None>
2022-01-17 11:41:11 +00:00
Ashwini Mhatre f8d0e4f399
Fix issue of not running tests in network ee for some targets (#106)
Fix issue of not running tests in network ee for some targets

SUMMARY

fix issue of some integration targets was not running in network ee.

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Matt Martz <matt@sivel.net>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: None <None>
2021-10-27 18:12:24 +00:00
Ashwini Mhatre b96738eacf
Fixed network ee jobs for utils (#96)
Fixed network ee jobs for utils

Reviewed-by: None <None>
2021-09-07 12:00:26 +00:00
Rohit Thakur 2f071599d0
resource_list_compare filter plugin added (#89)
resource_list_compare filter plugin added

Signed-off-by: Rohit Thakur rohitthakur2590@outlook.com
SUMMARY

resolves: #88

Test Coverage
plugins/filter/param_list_compare.py	 	95%
tests/unit/plugins/filter/test_param_list_compare.py	 	100%
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Ganesh Nalawade <None>
Reviewed-by: Bradley A. Thornton <bthornto@redhat.com>
Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
Reviewed-by: None <None>
2021-08-12 05:15:44 +00:00
Ashwini Mhatre 61a826c997
Update validate to use 2.11 ArgumentSpecValidator if available (#86)
Update validate to use 2.11 ArgumentSpecValidator if available

SUMMARY

fixes: #85

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bradley A. Thornton <bthornto@redhat.com>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: None <None>
2021-08-03 08:04:33 +00:00
Ashwini Mhatre 45eb99fb94
Add support for the validation of formats to the json schema validator (#83)
Add support for the validation of formats to the json schema validator

SUMMARY

fixes: #81

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Ganesh Nalawade <None>
2021-06-28 13:27:51 +00:00
stoned 0a2e083c9b
Make to_paths handles empty list and mapping (#58)
Make to_paths handles empty list and mapping

Reviewed-by: https://github.com/apps/ansible-zuul
2021-06-17 07:26:13 +00:00
Priyam Sahoo 1b76548d9d
Added 'usable_range' filter plugin (#77)
Added 'usable_range' filter plugin

Reviewed-by: https://github.com/apps/ansible-zuul
2021-06-03 07:17:07 +00:00
Priyam Sahoo 2636312822
Added 'resolvable' test plugin (#74)
Added 'resolvable' test plugin

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-14 20:24:11 +00:00
Priyam Sahoo 86923a5f2d
Added 'subnet_of', 'supernet_of', 'unspecified' IP test plugins (#73)
Added 'subnet_of', 'supernet_of', 'unspecified' IP test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-14 14:01:41 +00:00
Priyam Sahoo e57f25a510
Added 'private', 'public', 'reserved' test plugins (#72)
Added 'private', 'public', 'reserved' test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-12 15:42:19 +00:00
Priyam Sahoo 0c315db82e
Added 'loopback', 'mac', and 'multicast' test plugins (#71)
Added 'loopback', 'mac', and 'multicast' test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-11 16:23:05 +00:00
Priyam Sahoo 842549a236
Added ipv6 test plugins (#70)
Added ipv6 test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-10 18:19:24 +00:00
Priyam Sahoo e92cc6e78d
Added ipv4 specefic test plugins (#69)
Added ipv4 specefic test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-07 18:30:00 +00:00
Priyam Sahoo 1c9866e8d8
Added 'ip', 'ip_address' test plugins (#68)
Added 'ip', 'ip_address' test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-06 11:12:27 +00:00
Priyam Sahoo c09bbacdbc
Added 'in_any_network', 'in_network', 'in_one_network' test plugins (#66)
Added 'in_any_network', 'in_network', 'in_one_network' test plugins

Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-03 14:22:35 +00:00