a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cloudflare_dns: fix KeyError (#243) 

Fix errors of the type KeyError: 'success' to show a more meaningful message

Fixes: #236
pull/257/head
Lucas Basquerotto 2020-04-29 03:28:10 -03:00 committed by GitHub
parent 8a45044ea7
commit 055c18c892
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/243-cloudflare_dns_fix_keyerror.yml Normal file
View File

@ -0,0 +1,2 @@
bugfixes:
- cloudflare_dns - fix KeyError 'success' (https://github.com/ansible-collections/community.general/issues/236).

4
plugins/modules/net_tools/cloudflare_dns.py
View File

@ -496,6 +496,10 @@ class CloudflareAPI(object):
if result is None: if result is None:
self.module.fail_json(msg=error_msg) self.module.fail_json(msg=error_msg)
if 'success' not in result:
error_msg += "; Unexpected error details: {0}".format(result.get('error'))
self.module.fail_json(msg=error_msg)
if not result['success']: if not result['success']:
error_msg += "; Error details: " error_msg += "; Error details: "
for error in result['errors']: for error in result['errors']: