08f270ad71
Send empty command before recv
...
On some switches, starting an SSH connection and immediately calling
recv() will result in a connection timeout. The switch requires some
input on the channel before it provides any prompt.
As such, this patch sends an empty command immediately upon connection,
triggering the switch to send a prompt which the shell can then
interpret.
Signed-off-by: Devananda van der Veen <devananda.vdv@gmail.com>
2016-03-10 11:11:18 -08:00
9318727021
corrected changed_when handling
2016-03-09 16:09:05 -05:00
7f233c4c5e
Updating submodule refs
2016-03-09 15:52:23 -05:00
331f62f769
Update submodule refs
2016-03-09 11:28:49 -08:00
0628951ac6
Handle shlex incompatibility between python2.6 and python3
2016-03-09 11:27:19 -08:00
c0e2dd1693
Fix ssh connection plugin to work with python3
2016-03-09 11:17:10 -08:00
2b8a0cdddc
Fix ssh connection unittests for python3.4
2016-03-09 11:14:02 -08:00
eb463fab00
Also changing ansible-shell -> ansible-console in cli code comments
2016-03-09 13:53:52 -05:00
369b3b317e
renamed shell to console in last spot
2016-03-09 13:57:45 -05:00
9d61a6cba8
Fixing PlayIterator bugs
...
* Unit tests exposed a problem where nested blocks did not correctly
hit rescue/always portions of parent blocks
* Cleaned up logic in PlayIterator
* Unfortunately fixing the above exposed a potential problem in the
block integration tests, where a failure in an "always" section may
always lead to a failed state and the termination of execution
beyond that point, so certain parts of the block integration test
were disabled.
2016-03-09 13:31:30 -05:00
d7bd5fc075
Merge pull request #14824 from bcoca/ansible_shell
...
draft 1st release of ansible shell
2016-03-09 13:21:25 -05:00
cf250d4f89
Merge pull request #14833 from bcoca/when_lists
...
make all conditionals lists
2016-03-09 13:20:31 -05:00
cf729fcb82
Merge pull request #14882 from emonty/devel
...
Detect empty cache files in openstack inventory
2016-03-09 12:08:33 -06:00
82c150b72f
Detect empty cache files in openstack inventory
...
There are cases where it makes more sense to zero out a cache file as a
form of invalidation instead of removing it. Detect those approrpriately
2016-03-09 11:54:30 -06:00
7067bb32b8
make all conditionals lists
...
this brings them to equivalence with when:
fixes #13905
2016-03-09 09:33:59 -05:00
a52a561217
Merge pull request #14874 from mattclay/misplaced-paren
...
Fix misplaced paren.
2016-03-09 09:14:16 -05:00
33f93f9241
Fix misplaced paren.
2016-03-08 22:16:23 -08:00
b01caa371f
Don't use notices for travis irc messages
2016-03-08 15:35:04 -05:00
aee2eb6287
Merge pull request #14864 from dagwieers/patch-12
...
Only show diff when the task actually induced a change
2016-03-08 15:02:49 -05:00
1a5ee115f0
Fixing minor logic error in error detection/handling in ssh connection plugin
...
If max retries were reached, no AnsibleConnectionFailure was raised, which
means potentially in some cases an unreachable error might not be returned
2016-03-08 14:50:35 -05:00
f0d3284ead
Adding more unit tests for ssh connection plugin
2016-03-08 14:50:35 -05:00
664f58d12a
Merge pull request #14863 from dagwieers/patch-11
...
Little improvement in callback flow
2016-03-08 11:36:50 -05:00
f5b6f52940
Only show diff when the task actually induced a change
...
This implements solution #1 in the proposal #14860 .
It only shows the diff if the task induced a change, which means that if the changed_when control overrides the task, not diff will be produced.
See #14860 for a rationale and the use-case.
2016-03-08 17:33:29 +01:00
175351f200
Little improvement in flow
...
Don't get the hostname if it's not needed.
2016-03-08 17:23:34 +01:00
49bb4803b5
clarify --step prompt
...
now shows full words and indicates default
fixes #7433
2016-03-08 10:57:54 -05:00
3d6ec52e83
Merge pull request #14830 from bcoca/assemble_fix
...
fix assemble to not pass extra args to copy/file
2016-03-08 09:22:15 -05:00
eb4cb46c84
Merge pull request #14859 from sivel/issue/14858
...
Strip proc_1 before testing it. Fixes #14858
2016-03-08 09:14:05 -05:00
2f90a4f4e2
Strip proc_1 before testing it. Fixes #14858
2016-03-08 07:42:42 -06:00
2f472fd4e9
Adding start of ssh connection unit tests
2016-03-08 01:07:16 -05:00
22344c5320
Merge pull request #14812 from mattclay/test-connection
...
Add tests for connection plugins.
2016-03-08 04:17:30 +00:00
e24e619cf1
added stderr from vault script to error
2016-03-07 20:51:58 -05:00
75ae62a978
Merge pull request #12674 from sudarkoff/fail_if_executable_password_file_returns_nonzero
...
(TRIVIAL) Fail if the vault password script returns non-zero.
2016-03-07 20:45:26 -05:00
e74ab3ecdd
draft 1st release of ansible-console
...
porting @dominis 's ansible-shell tool from 1.9 and integrating it into ansible
added verbosity control
made more resilitent to several errors
added highlight color, to configurable colors
more resilient on exception and interruptions
prompt coloring, goes red and changes to # when using become = true and root
become setting is now explicit and not a toggle
2016-03-07 20:25:21 -05:00
8aee648bc9
Add as dependency of the parsing make target
2016-03-07 17:38:47 -06:00
bb23304b10
Merge pull request #14852 from sivel/fix-redirects-get-url
...
Fix redirects get url
2016-03-07 16:35:21 -06:00
53bb889ef6
update submodule refs
2016-03-07 16:12:19 -06:00
098333b2ec
Fix redirects for get_url
...
* fetch_url shouldn't both accept follow_redirects and support follow_redircts via module.params
* Default follow_redirects for open_url should be 'urllib2'
* Add redirect test for get_url
2016-03-07 15:44:31 -06:00
a302ba0ab4
Merge pull request #14810 from chouseknecht/docker_network_proposal
...
Updating docker_network module proposal
2016-03-07 15:34:12 -05:00
7c18dfbd5a
Merge pull request #14799 from chouseknecht/auto_role_install_prop
...
14604 - Adding suggested comments related to securing Galaxy role ver…
2016-03-07 15:31:59 -05:00
d23c7949eb
Merge pull request #14842 from resmo/patch-4
...
proposal: publish/subscribe for handlers
2016-03-07 15:20:31 -05:00
325fccfa78
added v for least verbose display function
2016-03-07 13:17:31 -05:00
299d93f6e9
Updating unit tests for PlayIterator
...
This knowingly introduces a broken test, planning to fix that later.
2016-03-07 13:03:06 -05:00
66ea464ebd
Merge pull request #14793 from xiaket/devel
...
remove main_q for simplicity.
2016-03-07 12:51:38 -05:00
90948cd37b
Merge pull request #14838 from resmo/patch-3
...
Proposal: re-run-handlers
2016-03-07 09:50:49 -05:00
25e9b5788b
add per item diff handling
...
fixes #14843
2016-03-07 09:49:18 -05:00
f0b2af2f9d
Merge pull request #14847 from bob-smith/errormsg
...
Make it easier to read error message
2016-03-07 08:52:54 -05:00
8b4ebd8e4a
Make it easier to read error message
2016-03-07 12:49:41 +00:00
66cb77107b
proposal: publish/subscribe for handlers
2016-03-07 13:00:05 +01:00
d361f3b44e
proposal: re-run handlers
2016-03-07 07:58:34 +01:00
d60f0c94f8
Merge pull request #14834 from chouseknecht/docker_one
...
Updating docker_container module proposal
2016-03-06 11:46:50 -05:00
Devananda van der Veen
Brian Coca
James Cammarata
Toshio Kuratomi
Brian Coca
Matt Martz
Monty Taylor
Matt Clay
Dag Wieers
Matt Davis
John Barker
René Moser