a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
45,088 Commits
12 Branches
186 Tags
285 MiB
Commit Graph

713 Commits (78b003858d6dc261987db08798cd4d14c4e607da)

Author SHA1 Message Date
Trishna Guha d5e9653c96
Add get_capabilities in nxapi module_utils (#42688) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-07-13 11:11:35 +05:30
Nilashish Chakraborty ed5a0f2d9c
nxos_logging new feature - remote logging (#41237) 
* Added feature - Remote Logging + More tests

* Fixed Shippable Errors

* Fixes - new feature version added error
 2018-07-05 12:17:14 +05:30
Trishna Guha 805d13f287
nxos CI failures bugfix (#42240) 
* fix nxos_portchannel and remove deprecated param in test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix _nxos_switchport CI failures

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxapi nxos_command test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove unsupported param nxos_smoke test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxos_vxlan_vtep_vni

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* syntax error

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-07-03 19:45:19 +05:30
Trishna Guha 0e05425b32
Refactor nxos cliconf get_device_info and add requirements for JSON structured output support in nxos_facts module (#42089) 
* nxos_facts requires JSON structured output support

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* refactor get_device_info for legacy devices

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update additional logic

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-07-03 19:44:50 +05:30
tstoner db7300904d Enforcing NXAPI default HTTP behavior (#41817) 
* nxos_nxapi http default behavior

* Use nxos_nxapi module in prepare_nxos_tests

* Refactor nxos_nxapi configure test to use yaml block

* Extend nxos_nxapi https & http test cases

* Removed NXOS internal release naming

* Resolved ansibot sanity errors

* Fix typo in prepare_nxos_tests

* Address PR comments

* Shippable indicates this is no longer needed

* Add port change logic and testing
 2018-07-02 14:58:37 -04:00
Trishna Guha 981c9f6a79
fix nxos_vxlan_vtep_vni issue (#42183) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-07-02 19:32:29 +05:30
saichint bd9b8b422d fix nxos_gir issues (#41809) 
* fix nxos_gir issues

* review comments
 2018-06-28 10:11:45 +05:30
saichint 119e6d680b fix nxos_linkagg issue (#41550) 
* fix nxos_linkagg issue

* fix shippable
 2018-06-16 20:23:29 +05:30
Trishna Guha 8ab0d654f3
don't retrieve config in running_config when config is provided for diff (#41400) 
* don't retrieve config in running_config when config is provided for diff

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix for eos, nxos

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-06-14 18:02:19 +05:30
saichint 79dd206b3e fix reload smu issue (#41270) 
* fix reload smu issue

* review comments
 2018-06-14 09:17:33 +05:30
saichint 00ce205535 fix get existing vpc issue (#41429) 2018-06-12 10:46:47 +05:30
Trishna Guha 1998707eda
Fix nxos_snapshot compare (#41386) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-06-11 15:26:01 +05:30
Chris Smolen d6fb00e797 add example using peer keepalive vrf and delay restore (#41111) 
* add example using peer keepalive vrf and delay restore

<!--- Your description here -->
add example using peer keepalive vrf and delay restore
+label: docsite_pr
+label: issue ansible/community#311

* Update nxos_vpc.py

update task name to include "existing"
 2018-06-08 09:51:36 -05:00
saichint 9abc3dbec4 nxos_rpm module (#40849) 
* Add nxos_rpm feature

* fix timing issues

* fix timing issues

* shippable fix

* review comment

* review comments fixes

* typo fix
 2018-06-06 10:09:38 +05:30
saichint 6733bffd5d fix nxos_snapshot issues (#41034) 
* fix nxos_snapshot issues

* review comments

* doc change
 2018-06-05 10:56:32 +05:30
Trishna Guha 72d630b831
fix nxos_udld failing with httpapi (#41074) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-06-04 11:31:32 +05:30
saichint b6afb77a8a fix nxos_banner issue (#41026) 2018-06-04 10:53:04 +05:30
Nathaniel Case 82dfa542c2
Replace bogus (but routeable) ip addresses with RFC 5737 example addresses (#40554) 
* Remove 1.1.1.1 from *_config tests

* remove from *_smoke and *_system

* Miscellaneous other tests

* Remove from module documentation as well

* Remove from unit tests as well

* Remove accidental duplication from rebase
 2018-05-30 13:03:20 -04:00
Trishna Guha 786ec14e54
fix nxos dci failures (#40871) 
* fix structured output for nxos_linkagg

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix TypeError for nxos_interface

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-05-30 15:31:16 +05:30
Trishna Guha 17b6ecf101
nxos_vlan fix (#40822) 
* nxos_vlan fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* uncomment mode test as nxapi now has get_capabilities

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-05-29 21:44:19 +05:30
Trishna Guha a7421e8611
httpapi fix nxos (#40806) 
* httpapi fix nxos

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* nxos_hsrp fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-05-29 21:43:34 +05:30
Mike Wiebe 9f026309a6 Update nxos_install_os module (#40102) 
* Add nxos_install_os integration tests

* Update call to check timers

* Update check_ansible_timer method

* Modify network_cli integration tests

* Add timer check for nxos_install_os

* Add comments for clear_persistent_sockets

* Update connection info for tests

* More updates

* Restructure files for provider and non-provider testing

* Update env var name and add check for ISSU switchover
 2018-05-29 21:07:57 +05:30
Trishna Guha b4baa2d484
fix nxos_vrf and migrate get_interface_type to module_utils (#40825) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-05-29 21:06:08 +05:30
James Mighion d9533c3cbf Adding changed option to save_when (#40640) 
* Adding changed option to save_when

* Fixing version when changed was added.
 2018-05-24 22:18:59 +05:30
Trishna Guha c2f7f36fc5
nxos_file_copy network_cli and httpapi fix (#40592) 
* Leverage action plugin to pass credentials to nxos_file_copy for network_cli, httpapi

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* make sure local test uses provider

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* clarify action plugin comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add connection=local back to nxos_file_copy because that module is weird

Also blacklist it running on nxapi, because that is meaningless

* remove provider

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* blacklist nxapi

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-05-24 20:21:18 +05:30
Dag Wieers d04a989bd2 nxos_interface: Disable switchport for loopback/svi (#40314) 
* nxos_interface: Disable switchport for loopback/svi

* Replace interface_type with get_interface_type(name)
 2018-05-24 08:51:17 +05:30
Trishna Guha 0b7932db30
add normalize_interface in module_utils and fix nxos_l3_interface module (#40598) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-05-23 21:42:58 +05:30
saichint 97070c9688 fix nxos_system issues (#40347) 2018-05-22 14:19:34 +05:30
Mike Wiebe 63e16431b7 Fix legacy Nexus 3k integration test and module issues. (#40322) 
* Add setup ignore_errors for nxos_config test

* Fix parse_fan_info for n3k

* Skip bidir tests for N3k

* Omit vni config for n3k

* Skip unsupported nxos_vrf_af test on N3K

* Add legacy N3K platform tag
 2018-05-17 20:29:00 +05:30
Trishna Guha 979f1e5ed1
save_snapshot_locally nxos_snapshot (#40227) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-05-16 14:59:23 +05:30
saichint 6fac574f17 fix nxos_ping issues (#40028) 2018-05-14 11:29:18 +05:30
Trishna Guha f1103a7a02
remove purge from nxos_logging doc, argspec (#39947) 
* remove purge from nxos_logging doc, argspec

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* shippable

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-05-10 15:28:37 +05:30
saichint e3bfbe5875 fix nxos_snmp_user issues (#39760) 
* fix nxos_snmp_user issues

* shipppable fix
 2018-05-08 11:57:12 +05:30
Trishna Guha 3c35dd4f7f
nxos_linkagg normalize interface (#39591) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-05-08 11:15:05 +05:30
Trishna Guha 9eff1f1d74
Handle nxos_feature issue where json isn't supported (#39150) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-05-04 12:21:58 +05:30
saichint f99bae1776 Fix for nxos_snmp_host issues (#39642) 
* fix snmp_host issues

* source files

* fix shippable

* remove defaults to match arg spec
 2018-05-03 21:36:33 +05:30
saichint 99748cbfa4 fix nxos_snmp_traps issues (#39444) 
* fix snmp_traps code

* add IT cases

* fix shippable

* fix shippable without ignore
 2018-05-03 21:34:25 +05:30
Dag Wieers dca6e2d94d nxos_interface: AttributeError: 'NoneType' object has no attribute 'group' (#38544) 
This fixes an issue we recently encounteredi with nxos_interface:

```
Traceback (most recent call last):
  File "/tmp/ansible_JmLoba/ansible_module_nxos_interface.py", line 777, in main
    have = map_config_to_obj(want, module)
  File "/tmp/ansible_JmLoba/ansible_module_nxos_interface.py", line 606, in map_config_to_obj
    obj['speed'] = re.search(r'speed (\d+)', body).group(1)
AttributeError: 'NoneType' object has no attribute 'group'
```
 2018-04-26 12:27:35 +05:30
saichint 2f99a17856 fix nxos_ntp issues (#39178) 
* fix nxos_ntp issues

* review comments

* fix idempotent fail case
 2018-04-26 12:09:46 +05:30
saichint 1afec5a48e fix nxos_snmp_community issues (#39258) 2018-04-25 13:16:41 +05:30
Trishna Guha 86817cdd52
Add aggregate example in nxos_l2_interface module doc (#39275) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-04-25 12:56:54 +05:30
Trishna Guha 6db3f522c8
sub-interface support for nxos module (#37392) 
* nxos sub-interface support

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update l3_interface test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-04-25 12:45:56 +05:30
John R Barker 7c4b91844d
More validate module fixes (#39097) 
* Fix type bool DOCUMENTATION issues
 2018-04-24 18:05:50 +01:00
saichint 6eecbf10e6 fix nxos_igmp_interface issues (#38752) 
* fix nxos_igmp_interface issues

* shippable fix

* fix oif_prefix and oif_source

* shippable fix

* shippable fix

* shippable fix

* add an example for oif_ps

* review comments

* review comments

* more review comments

* fix typo
 2018-04-23 20:38:49 +05:30
Alicia Cozine 0ebc0b9e5a adds FAQ TOC entry, links & examples to modules (#38706) 
* adds FAQ TOC entry, links & examples to modules
* moves link to Notes, corrects examples
 2018-04-18 11:41:54 -07:00
saichint a372142434 fix ntp_auth issues (#38824) 2018-04-17 08:25:05 -04:00
saichint 1d975bdc93 fix nxos_ntp_options (#38695) 2018-04-13 06:17:32 -04:00
Deepak Agrawal 6de49f084c
doc for _config backup argument (#38650) 2018-04-13 12:48:49 +05:30
saichint ed42331105 fix nxos_igmp_snooping issues (#38566) 
* fix nxos_igmp_snooping issue

* shippable error fix
 2018-04-11 10:14:27 -04:00
saichint 361437b042 fix nxos_igmp issues (#38496) 2018-04-10 00:05:58 -04:00
saichint dabe5e6d07 fix nxos_hsrp issues (#38410) 
* fix nxos_hsrp issues

* shippable fix

* add examples for md5 auth
 2018-04-09 23:54:05 -04:00
saichint 1bf29651af fix nxos_acl issues (#38283) 
* fix nxos_acl issues

* typo fix

* typo fix in sanity.yaml

* another typo fix in sanity.yaml
 2018-04-06 00:57:13 -04:00
Trishna Guha 119352b538
nxos_vlan purge (#38202) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-04-03 02:53:44 -04:00
saichint 24cc6b80bd fix nxos_aaa_server_host issues (#38188) 2018-04-03 01:53:43 -04:00
saichint 697c301f04 fix nxos_aaa_server issues (#38117) 2018-04-02 07:56:06 -04:00
saichint 6f2cb28bb9 fix nxos_vlan issues (#38008) 2018-03-29 06:26:33 -04:00
saichint 135d343254 fix nxos_udld_interface issue (#37527) 2018-03-27 02:57:14 -04:00
saichint 0df5cfd41f fix nxos_static_route issues (#37614) 
* fix nxos_static_route issues

* remove nxos_static_route from ignore
 2018-03-26 11:13:32 -04:00
Trishna Guha 00abe6dbe7
fix UnboundLocalError nxos_bgp_af module (#37610) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-03-20 01:53:08 +05:30
Dag Wieers cdd21e2170
Clean up module documentation (#36909) 
* Clean up module documentation

This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required

* Fix remaining (new) validation issues
 2018-03-15 22:15:24 +01:00
saichint 05b266cc66 fix nxos_udld issues (#37418) 2018-03-15 15:37:46 +05:30
saichint dc61f4c6b1 Fix nxos_vrf issues (#37092) 
* fix nxos_vrf issues

* fix doc
 2018-03-13 17:08:37 +05:30
Trishna Guha ba5e562c76
Fix nxos_l2_interface and test typo (#37336) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-03-13 13:36:38 +05:30
Mike Wiebe ff57fd0bb4 Fix nxos_switchport (#37328) 2018-03-13 12:03:05 +05:30
Trishna Guha 2501834c42
add nxos_snapshot test for missing required param (#37248) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-03-09 17:47:14 +05:30
Trishna Guha a10df8b0b5
fix required args for nxos_snapshot and docs improvement (#37232) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-03-09 14:08:01 +05:30
saichint 74e79d9f5e fix nxos_vrf_af issues (#37211) 2018-03-09 12:20:27 +05:30
Trishna Guha 02999b77a4
fix nxos_switchport/l2_interface trunk_vlans state absent (#37180) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-03-08 18:10:04 +05:30
John R Barker ebc71bcb16
Network modules to link to network guide (#37033) 
* Network modules to link to network guide

* Make it clear what's deprecated
* enable -> become
* Detail when provider is still needed (eAPI/NX-API)
* Link to specific sections
* rx_rate & tx_rate to link to conditional docs
 2018-03-06 12:01:07 +00:00
saichint 4ed0e5072d fix nxos_vrrp issues (#36930) 2018-03-06 13:36:50 +05:30
Mike Wiebe 51e8eab9db Fix n3k separate to combined image upgrade (#37017) 
* Fix n3k separate to combined image upgrade

* Address review comments
 2018-03-06 10:05:08 +05:30
Trishna Guha 2fbfce06e7
Fix nxos_interface multiple issues (#36827) 
* fix interface_type

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* speed idempotence and add unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fabric_forwarding_anycast_gateway applicable for svi type intf only

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix speed

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-03-01 10:56:16 +05:30
saichint db43fe6a76 nxos_facts fix and integration tests (#36796) 
* fix nxos_facts ipv6 error

* time_range not supported for N35
 2018-02-28 10:45:50 +05:30
Trishna Guha 44332bda78
fix nxos_vlan aggregate (#36710) 
* fix nxos_vlan aggregate

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-02-26 12:29:49 +05:30
Trishna Guha d6912cf40e
nxos_linkagg fix (#36706) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-02-26 11:21:51 +05:30
Ganesh Nalawade 5a6b893240
Decouple config and state check in vlan and vrf network modules (#36386) 
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules

Fixes #35567
Fixes #34754

`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.

Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.

* Fix CI failures

* Fix review comment

* Fixed integration test failure
 2018-02-26 09:23:54 +05:30
Trishna Guha 713828804d
nxos_vrf fix (#36494) 
* nxos_vrf fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Address review

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-02-21 19:33:33 +05:30
Trishna Guha 9598978e12
fix nxos_pim module doc (#36505) 
* fix nxos_pim module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review
 2018-02-21 18:42:37 +05:30
Lindsay Hill f207897f32 fixed conditional error message (#36476) 2018-02-21 11:44:18 +05:30
saichint 47a92386c9 fix nxos_bgp_neighbor_af issues (#36472) 2018-02-21 10:20:24 +05:30
Mike Wiebe ef7d574920 Fix nxos_banner module for unstructured output (#36411) 
* Fix nxos_banner module for unstructured output

* Refactor and bug fixes

* Fix pep8 error
 2018-02-21 09:51:41 +05:30
saichint 80d19e6af3 fix nxos_bgp_neighbor issues (#36318) 2018-02-20 10:08:17 +05:30
Trishna Guha 736d6406c0
fix nxos_config json pipeline error (#36236) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-02-19 10:11:43 +05:30
Mike Wiebe 6e096cb0c9 Remove kickstart_image_required check (#36319) 2018-02-17 10:20:31 +05:30
rahushen e24c547a3a Fixes for the N3500 platform that uses the A8 image (#36261) 
* fix nxos_l3_interface tests as n35 doesn't support ipv6

* add terminal dont-ask to nxos_feature and nxos_lldp

* put interfaces in L2 mode for N35

* fix nxos_feature unit-tests
 2018-02-17 10:16:03 +05:30
Mike Wiebe ac169f5ffd Fix structured output bug (#36193) 2018-02-16 21:34:26 +05:30
saichint 75a34f6668 fix nxos_bgp_af issues (#36147) 
* fix nxos_bgp_af issues

* shippable fix

* review comments

* shippable error fix
 2018-02-16 09:34:24 +05:30
saichint eab1b62cd2 fix nxos_interface_ospf issues (#35988) 
* fix nxos_interface_ospf issues

* review comment
 2018-02-13 09:27:22 +05:30
Mike Wiebe 7a711cf942 Fix nxos_igmp_interface for diff nxos versions (#35959) 2018-02-12 10:30:38 +05:30
Tyler 15b0371eb2 Add examples and language to better showcase the 'parents' parameter in multiple network modules (#34486) 
* Add additional language and examples for 'parents' parameter to clarify its usage.
 2018-02-09 13:31:37 +00:00
saichint c7305393a3 fix nxos_evpn_vni issues (#35930) 2018-02-09 13:02:41 +05:30
saichint 80fcfdc0d1 fix nxos_vpc issues (#35868) 2018-02-08 18:50:37 +05:30
Nathaniel Case dfcae9fc8e
Remove potentially confusing `provider` from module documentation (#35851) 2018-02-07 16:33:11 -05:00
saichint c9e0ce1d7d fix nxos_vpc_interface peer_link idempotence (#35737) 
* fix peer_link idempotence

* review comment
 2018-02-07 08:35:43 +05:30
chifu1234 98f804ecb4 nxos_facts: svi support ipv4 (#35222) 
* nxos_facts: svi support ipv4

* nxos_facts: copy paste error

* https://app.shippable.com/github/ansible/ansible/runs/51845/1/tests

* E111 indentation is not a multiple of four

* Update nxos_facts.py
 2018-02-06 19:40:12 +05:30
saichint 109bc89bbe fix nxos_ospf_vrf issues (#35616) 2018-02-05 10:59:13 +05:30
Trishna Guha a4b7df70c7
nxos_vlan ValueError fix (#35559) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-02-02 20:51:34 +05:30
saichint dc35baa8db fix nxos_pim_interface issues (#35405) 
* fix nxos_pim_interface issues

* add absent test for pim_interface
 2018-01-31 10:51:11 +05:30
John R Barker a23c95023b
Module deprecation: docs, scheme and tests (#34100) 
Enforce module deprecation.
After module has reached the end of it's deprecation cycle we will replace it with a docs stub.

* Replace deprecated modules with docs-only sub
* Use of deprecated past deprecation cycle gives meaningful message (see examples below)
* Enforce documentation.deprecation dict via `schema.py`
* Update `ansible-doc` and web docs to display documentation.deprecation
* Document that structure in `dev_guide`
* Ensure that all modules starting with `_` have a `deprecation:` block
* Ensure `deprecation:` block is only used on modules that start with `_`
* `removed_in` A string which represents when this module needs **deleting**
* CHANGELOG.md and porting_guide_2.5.rst list removed modules as well as alternatives
* CHANGELOG.md links to porting guide index

To ensure that meaningful messages are given to the user if they try to use a module at the end of it's deprecation cycle we enforce the module to contain:
```python
if __name__ == '__main__':
    removed_module()
```
 2018-01-30 12:23:52 +00:00
Chip Gwyn 2293252e52 bug-35431 fixed removing encryption from user on subsequent runs of the task (#35433) 2018-01-30 11:26:54 +05:30
Trishna Guha f8a89f120f
update nxos_interface doc (#35350) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-25 20:02:02 +05:30
Trishna Guha cff4a2d26e
fix *os_config module backward diff (#35332) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-25 18:49:20 +05:30
saichint 0b30c42902 fix pim rp_address issues (#35248) 2018-01-24 11:48:49 +05:30
saichint 4bc22be614 Fix for nxos_pim issues (#35103) 
* fix nxos_pim issues

* unused line removed

* unused line removed

* remove unnecessary files
 2018-01-22 11:30:52 +05:30
Trishna Guha 8a6d699198
Enable nxapi nxos_banner test (#35033) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-18 11:50:15 +05:30
John R Barker 9a32f5c889 Add missing extends_documentation_fragment (#35013) 
NXOS modules need more work, though that will all be in
module_docs_fragments/nxos.py
 2018-01-17 16:31:53 -05:00
John R Barker db61f8f967
Clarify which ping module to use (#34935) 
* Clarify which ping module to use

Ensure each of the ping modules link to each other

ping - Requires Python on remote-node
nxos_ping - Only on Cisco NXOS
ios_ping - Only on Cisco IOS
net_ping - For network devices
win_ping - only for Windows
 2018-01-17 14:02:06 +00:00
saichint 3a144b290d fix for nxos_vxlan_vtep_vni issues (#34946) 
* fix vxlan_vtep_vni issues

* pep8 errors
 2018-01-17 11:07:29 +05:30
Matt Clay 227ff61f9d
Add module support to yamllint sanity test. (#34964) 
* Add module support to yamllint sanity test.
* Fix duplicate keys in module RETURN docs.
* Fix syntax in return_common docs fragment.
* Fix duplicate keys in module EXAMPLES docs.
 2018-01-16 15:08:56 -08:00
Trishna Guha a727930f07
Remove deprecated params from module argspec nxos modules (#34911) 
* Remove deprecated param from module argspec nxos modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxos_vrrp syntaxerror

* Add choices for version _nxos_ip_interface

* remove check_args function

* remove include_defaults
 2018-01-16 18:23:58 +05:30
John R Barker 195beebcb4
Module DOCUMENTATION should match argspec (#34895) 
* Module DOCUMENTATION should match argspec

Large update of many modules so that DOCUMENTATION option name and
aliases match those defined in the argspec.

Issues identified by https://github.com/ansible/ansible/pull/34809

In addition to many typos and missing aliases, the following notable
changes were made:

* Create `module_docs_fragments/url.py` for `url_argument_spec`
* `dellos*_command` shouldn't have ever had `waitfor` (was incorrectly copied)
* `ce_aaa_server_host.py` `s/raduis_server_type/radius_server_type/g`
* `Junos_lldp` enable should be part of `state`.
 2018-01-16 12:18:51 +00:00
Trishna Guha a65f702155
add config option to replace argument (#34342) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-15 21:17:02 +05:30
saichint c04cd8642d fix vxlan idempotent issue (#34750) 2018-01-15 12:27:37 +05:30
Trishna Guha 303894dd17
fix nxos_banner (#34695) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-11 21:13:00 +05:30
Trishna Guha df8b01aaf7
Handle platform os version for sandbox nxos_nxapi (#34490) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-11 21:12:00 +05:30
saichint 6f8d3ad70d Fixes for nxos_bgp (#34590) 
* fix bgp issues

* add new tests cases

* review comments
 2018-01-10 10:52:26 +05:30
Trishna Guha 5e6b2495c0
Convert nxos_vrf to DI module (#34274) 
* Convert nxos_vrf to DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add purge example and improve logic

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert version_added for rd param

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update test to use network_cli

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-08 10:10:34 +05:30
Nathaniel Case c371ed8d30
nxos tests to use network_cli (#34474) 
* Fix over-byte

* Fix nxos_l2_interface docs

* Update connections for tasks

* Add default ssh port

* Only report provider when using connection=local

* Send empty provider when connection=network_cli

* Fix find tasks
 2018-01-05 12:39:04 -05:00
John R Barker 2be5ad4f08 deprecation dict not live yet (#34493) 2018-01-05 03:28:53 -05:00
Trishna Guha 9d2182bcf8 Deprecate nxos_switchport and Add nxos_l2_interface DI module (#33813) 
* Deprecate nxos_switchport

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_l2_interface DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* aggregate test for nxos_l2_interface

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert nxos_switchport test change

* gundalow's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-05 07:44:02 +00:00
Pilou e9a5ff912a nxos_file_copy: fix broken import and 2.6 compatibility (#34480) 
* Fix broken import: paramiko could be missing

* doc: use formatting function

* Use Python 2.6 compatible format string
 2018-01-05 11:36:11 +05:30
Ganesh Nalawade ab67539bef
Add nxos_lldp module (#34453) 
* Add nxos_lldp module

*  Implemetation for nxos_lldp module
*  Integration test for nxos_lldp module

* Minor change
 2018-01-04 18:06:15 +05:30
bdowling 552d1df901 Adds parents to mutually_exclusive with src for *_config modules (#33957) 
* mutually_exclusive add - ios_config parents works with lines by not src

* mutually_execlusive parents,src added to all other net modules

* tests for mutually_exclusive parents,src and whitespce removal
 2018-01-03 09:47:12 -05:00
Trishna Guha 80ba767204
Convert nxos_interface to DI (#34240) 
* Convert nxos_interface to DI

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* commit for ganeshrn's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-12-28 16:41:09 +05:30
Trishna Guha 60f3649ebd
Convert nxos_vlan to DI module (#31866) 
* Convert nxos_vlan to DI

* fix conflict

* push fix for qalthos's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-12-21 14:08:33 +05:30
Trishna Guha 4a4da2b774
nxos_static_route DI module (#33797) 
* nxos_static_route DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add version_added
 2017-12-20 17:08:29 +05:30
Trishna Guha be89822bb5
Deprecate nxos_portchannel and add nxos_linkagg DI module (#33376) 
* deprecate nxos_portchannel

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_linkagg DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove nxos_portchannel unit test

* fix syntax issues

* fix ansible-doc failure

* update nxos_portchannel unittest

* minor fixes and integration test

* update nxos_linkagg
 2017-12-20 11:26:07 +05:30
Trishna Guha 3cce8dfafd
Deprecate nxos_ip_interface and Add nxos_l3_interface DI module (#33866) 
* Deprecate nxos_ip_interface module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_l3_interface DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* Add nxapi cli test

* Improve complexity

* manage layer3 interface

* fix unit test
 2017-12-20 11:07:23 +05:30
Trishna Guha 27be2a0f5a
Handle nxos platform diffs with cli conf implementation (#34020) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-12-20 10:41:10 +05:30
Trishna Guha 9f86b923e9
[CLI_CONF] Refactor nxos module common library to use cliconf plugin (#31524) 
* refactor nxos modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* get_config update

* fix get_config

* update nxos module

* device_info

* fix conflict

* add failure message check

* pep8 fixes

* use get_capabilities to check cliconf

* Add logic to detect platform in get_capabilities and cache in module_utils

* return msg in edit_config

* fix conflicts

* make modules compatible

* fix nxos cliconf api

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* cache capabilities

* Update transport queries to get_capabilities in module level

* fix unit tests

* load_config error code

* remove unnecessary change

* Refactor nxos_install_os module
 2017-12-19 12:22:33 +05:30
Ganesh Nalawade ea18b9021a
Revert "Deprecate Entity, EntityCollection and use subspec in network modules (#33575)" (#33849) 
This reverts commit 4349b56643.
 2017-12-13 13:07:52 +05:30
Trishna Guha c2b4fd7f1e
Convert non-DI module to DI nxos_user (#33770) 2017-12-11 20:55:05 +05:30
Ganesh Nalawade 4349b56643
Deprecate Entity, EntityCollection and use subspec in network modules (#33575) 
* Deprecate Entity, EntityCollection and use subspec in network modules

*  As per proposal https://github.com/ansible/proposals/issues/76
   deprecate use of Entity, EntityCollection, ComplexDict, ComplexList
   and use subspec instead.
*  Refactor ios modules
*  Refactor eos modules
*  Refactor vyos modules
*  Refactor nxos modules
*  Refactor iosxr modules
*  Add support for key in suboptions handling

* Fix CI issues
 2017-12-11 20:31:25 +05:30
John Barker 10cd2cd1b7 Manually fix issues that autopep8 introduced 
* iam.py 161 -> 160 chars
* lamba -> single line function -> multiline function

Avoid redefining key

iam line length

iam.py now clean
 2017-12-07 20:25:55 +00:00
John Barker c57a7f05e1 Bulk autopep8 (modules) 
As agreed in 2017-12-07 Core meeting bulk fix pep8 issues

Generated using:
autopep8 1.3.3 (pycodestyle: 2.3.1)
autopep8 -r  --max-line-length 160 --in-place --ignore E305,E402,E722,E741 lib/ansible/modules

Manually fix issues that autopep8 has introduced
 2017-12-07 20:25:55 +00:00
rahushen 1a12e733b9 nxos_facts: add check for ipv6 (#33594) 2017-12-06 09:41:31 -05:00
Abhijeet Kasurde 961c3fcca7 Add missing comma in lists (#33557) 
This fix adds missing comma in different modules.
This removes implicit string concatenation in given list.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2017-12-05 15:44:56 +01:00
Ganesh Nalawade 11c9ad23d5
Refactor common network shared and platform utils code into package (#33452) 
* Refactor common network shared and platform specific code into package (part-1)

As per proposal #76 refactor common network shared and platform specific
code into sub-package.
https://github.com/ansible/proposals/issues/76

*  ansible.module_utils.network.common - command shared functions
*  ansible.module_utils.network.{{ platform }} - where platform is platform specific shared functions

*  Fix review comments

* Fix review comments
 2017-12-03 21:42:30 +05:30
Trishna Guha 819f9ee8fa Add port arg to establish ssh connection in nxos_file_copy (#33304) 
* Add port arg to establish ssh connection in nxos_file_copy

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* resolve kedar's comment
 2017-11-28 10:54:23 +05:30
Trishna Guha 7b19c28438
nxos_vrf_interface fix (#33249) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-27 22:56:39 +05:30
Trishna Guha 25a465ffcb
loopback doesn't support passive_interface (#33252) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-27 22:56:16 +05:30
Matt Clay c6bb6c72cc Fix anomalous backslashes and enable pylint test. 2017-11-21 23:22:51 -08:00
Mike Wiebe 95a2140f4b Use show command to support wider platform set for nxos_interface module (#33037) 
* Use show command to support wider platform set

* Fix unit tests
 2017-11-20 18:59:09 +00:00
Arnaud 84117e57ba nxos: 32 bits AS in as-dot format not recognized by regexp asn_regex (#30569) 
* added test for 32 bits AS

* Lint not happy.
 2017-11-20 10:09:16 +00:00
Mike Wiebe 208208ab8f Fix nxos_snmp_host bug (#32916) 
* Fix nxos_snmp_host bug

* Enable nxos_snmp_host tests
 2017-11-16 06:17:42 +00:00
chifu1234 e2fef7beed nxos_facts: cdp support (#31202) 
* nxos_facts get CPD neighbor

* nxos_fact: cdp support

* remove blank spaces

* add ansible_net_neighbors cdp informations
 2017-11-15 07:38:19 -07:00
Trishna Guha 3ee2501c83
multiple fixes nxos (#32903) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-14 15:23:11 +00:00
Trishna Guha c40de24e9c
fix mtu check nxos_interface (#32880) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-14 10:40:37 +00:00
rahushen 1360ae6518 nxos_config and nxos_facts - fixes for N35 platform. (#32762) 
* update nxos_facts to handle errors in n35 platform

* switch show commands to output text

* replace basestring which is not supported in python3

* do it like the other modules: use string_types

* incorporate PR review
 2017-11-14 05:03:37 +00:00
Trishna Guha f49555d494
nxos_bgp_neighbor_af feature idea disable-peer-as-check (#32665) 
* nxos_bgp_neighbor_af feature idea disable-peer-as-check

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add unit test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-13 14:48:31 +00:00