f8a89f120f
update nxos_interface doc ( #35350 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-25 20:02:02 +05:30
cff4a2d26e
fix *os_config module backward diff ( #35332 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-25 18:49:20 +05:30
0b30c42902
fix pim rp_address issues ( #35248 )
2018-01-24 11:48:49 +05:30
4bc22be614
Fix for nxos_pim issues ( #35103 )
...
* fix nxos_pim issues
* unused line removed
* unused line removed
* remove unnecessary files
2018-01-22 11:30:52 +05:30
8a6d699198
Enable nxapi nxos_banner test ( #35033 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-18 11:50:15 +05:30
9a32f5c889
Add missing extends_documentation_fragment ( #35013 )
...
NXOS modules need more work, though that will all be in
module_docs_fragments/nxos.py
2018-01-17 16:31:53 -05:00
db61f8f967
Clarify which ping module to use ( #34935 )
...
* Clarify which ping module to use
Ensure each of the ping modules link to each other
ping - Requires Python on remote-node
nxos_ping - Only on Cisco NXOS
ios_ping - Only on Cisco IOS
net_ping - For network devices
win_ping - only for Windows
2018-01-17 14:02:06 +00:00
3a144b290d
fix for nxos_vxlan_vtep_vni issues ( #34946 )
...
* fix vxlan_vtep_vni issues
* pep8 errors
2018-01-17 11:07:29 +05:30
227ff61f9d
Add module support to yamllint sanity test. ( #34964 )
...
* Add module support to yamllint sanity test.
* Fix duplicate keys in module RETURN docs.
* Fix syntax in return_common docs fragment.
* Fix duplicate keys in module EXAMPLES docs.
2018-01-16 15:08:56 -08:00
a727930f07
Remove deprecated params from module argspec nxos modules ( #34911 )
...
* Remove deprecated param from module argspec nxos modules
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_vrrp syntaxerror
* Add choices for version _nxos_ip_interface
* remove check_args function
* remove include_defaults
2018-01-16 18:23:58 +05:30
195beebcb4
Module DOCUMENTATION should match argspec ( #34895 )
...
* Module DOCUMENTATION should match argspec
Large update of many modules so that DOCUMENTATION option name and
aliases match those defined in the argspec.
Issues identified by https://github.com/ansible/ansible/pull/34809
In addition to many typos and missing aliases, the following notable
changes were made:
* Create `module_docs_fragments/url.py` for `url_argument_spec`
* `dellos*_command` shouldn't have ever had `waitfor` (was incorrectly copied)
* `ce_aaa_server_host.py` `s/raduis_server_type/radius_server_type/g`
* `Junos_lldp` enable should be part of `state`.
2018-01-16 12:18:51 +00:00
a65f702155
add config option to replace argument ( #34342 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-15 21:17:02 +05:30
c04cd8642d
fix vxlan idempotent issue ( #34750 )
2018-01-15 12:27:37 +05:30
303894dd17
fix nxos_banner ( #34695 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-11 21:13:00 +05:30
df8b01aaf7
Handle platform os version for sandbox nxos_nxapi ( #34490 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-11 21:12:00 +05:30
6f8d3ad70d
Fixes for nxos_bgp ( #34590 )
...
* fix bgp issues
* add new tests cases
* review comments
2018-01-10 10:52:26 +05:30
5e6b2495c0
Convert nxos_vrf to DI module ( #34274 )
...
* Convert nxos_vrf to DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add purge example and improve logic
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* revert version_added for rd param
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update test to use network_cli
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-08 10:10:34 +05:30
c371ed8d30
nxos tests to use network_cli ( #34474 )
...
* Fix over-byte
* Fix nxos_l2_interface docs
* Update connections for tasks
* Add default ssh port
* Only report provider when using connection=local
* Send empty provider when connection=network_cli
* Fix find tasks
2018-01-05 12:39:04 -05:00
2be5ad4f08
deprecation dict not live yet ( #34493 )
2018-01-05 03:28:53 -05:00
9d2182bcf8
Deprecate nxos_switchport and Add nxos_l2_interface DI module ( #33813 )
...
* Deprecate nxos_switchport
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos_l2_interface DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* pep8 fixes
* aggregate test for nxos_l2_interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* revert nxos_switchport test change
* gundalow's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-05 07:44:02 +00:00
e9a5ff912a
nxos_file_copy: fix broken import and 2.6 compatibility ( #34480 )
...
* Fix broken import: paramiko could be missing
* doc: use formatting function
* Use Python 2.6 compatible format string
2018-01-05 11:36:11 +05:30
ab67539bef
Add nxos_lldp module ( #34453 )
...
* Add nxos_lldp module
* Implemetation for nxos_lldp module
* Integration test for nxos_lldp module
* Minor change
2018-01-04 18:06:15 +05:30
552d1df901
Adds parents to mutually_exclusive with src for *_config modules ( #33957 )
...
* mutually_exclusive add - ios_config parents works with lines by not src
* mutually_execlusive parents,src added to all other net modules
* tests for mutually_exclusive parents,src and whitespce removal
2018-01-03 09:47:12 -05:00
80ba767204
Convert nxos_interface to DI ( #34240 )
...
* Convert nxos_interface to DI
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* commit for ganeshrn's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-28 16:41:09 +05:30
60f3649ebd
Convert nxos_vlan to DI module ( #31866 )
...
* Convert nxos_vlan to DI
* fix conflict
* push fix for qalthos's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-21 14:08:33 +05:30
4a4da2b774
nxos_static_route DI module ( #33797 )
...
* nxos_static_route DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add version_added
2017-12-20 17:08:29 +05:30
be89822bb5
Deprecate nxos_portchannel and add nxos_linkagg DI module ( #33376 )
...
* deprecate nxos_portchannel
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos_linkagg DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove nxos_portchannel unit test
* fix syntax issues
* fix ansible-doc failure
* update nxos_portchannel unittest
* minor fixes and integration test
* update nxos_linkagg
2017-12-20 11:26:07 +05:30
3cce8dfafd
Deprecate nxos_ip_interface and Add nxos_l3_interface DI module ( #33866 )
...
* Deprecate nxos_ip_interface module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos_l3_interface DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* pep8 fixes
* Add nxapi cli test
* Improve complexity
* manage layer3 interface
* fix unit test
2017-12-20 11:07:23 +05:30
27be2a0f5a
Handle nxos platform diffs with cli conf implementation ( #34020 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-20 10:41:10 +05:30
9f86b923e9
[CLI_CONF] Refactor nxos module common library to use cliconf plugin ( #31524 )
...
* refactor nxos modules
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* get_config update
* fix get_config
* update nxos module
* device_info
* fix conflict
* add failure message check
* pep8 fixes
* use get_capabilities to check cliconf
* Add logic to detect platform in get_capabilities and cache in module_utils
* return msg in edit_config
* fix conflicts
* make modules compatible
* fix nxos cliconf api
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* cache capabilities
* Update transport queries to get_capabilities in module level
* fix unit tests
* load_config error code
* remove unnecessary change
* Refactor nxos_install_os module
2017-12-19 12:22:33 +05:30
ea18b9021a
Revert "Deprecate Entity, EntityCollection and use subspec in network modules ( #33575 )" ( #33849 )
...
This reverts commit 4349b56643
2017-12-13 13:07:52 +05:30
c2b4fd7f1e
Convert non-DI module to DI nxos_user ( #33770 )
2017-12-11 20:55:05 +05:30
4349b56643
Deprecate Entity, EntityCollection and use subspec in network modules ( #33575 )
...
* Deprecate Entity, EntityCollection and use subspec in network modules
* As per proposal https://github.com/ansible/proposals/issues/76
deprecate use of Entity, EntityCollection, ComplexDict, ComplexList
and use subspec instead.
* Refactor ios modules
* Refactor eos modules
* Refactor vyos modules
* Refactor nxos modules
* Refactor iosxr modules
* Add support for key in suboptions handling
* Fix CI issues
2017-12-11 20:31:25 +05:30
10cd2cd1b7
Manually fix issues that autopep8 introduced
...
* iam.py 161 -> 160 chars
* lamba -> single line function -> multiline function
Avoid redefining key
iam line length
iam.py now clean
2017-12-07 20:25:55 +00:00
c57a7f05e1
Bulk autopep8 (modules)
...
As agreed in 2017-12-07 Core meeting bulk fix pep8 issues
Generated using:
autopep8 1.3.3 (pycodestyle: 2.3.1)
autopep8 -r --max-line-length 160 --in-place --ignore E305,E402,E722,E741 lib/ansible/modules
Manually fix issues that autopep8 has introduced
2017-12-07 20:25:55 +00:00
1a12e733b9
nxos_facts: add check for ipv6 ( #33594 )
2017-12-06 09:41:31 -05:00
961c3fcca7
Add missing comma in lists ( #33557 )
...
This fix adds missing comma in different modules.
This removes implicit string concatenation in given list.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-05 15:44:56 +01:00
11c9ad23d5
Refactor common network shared and platform utils code into package ( #33452 )
...
* Refactor common network shared and platform specific code into package (part-1)
As per proposal #76 refactor common network shared and platform specific
code into sub-package.
https://github.com/ansible/proposals/issues/76
* ansible.module_utils.network.common - command shared functions
* ansible.module_utils.network.{{ platform }} - where platform is platform specific shared functions
* Fix review comments
* Fix review comments
2017-12-03 21:42:30 +05:30
819f9ee8fa
Add port arg to establish ssh connection in nxos_file_copy ( #33304 )
...
* Add port arg to establish ssh connection in nxos_file_copy
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* resolve kedar's comment
2017-11-28 10:54:23 +05:30
7b19c28438
nxos_vrf_interface fix ( #33249 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-27 22:56:39 +05:30
25a465ffcb
loopback doesn't support passive_interface ( #33252 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-27 22:56:16 +05:30
c6bb6c72cc
Fix anomalous backslashes and enable pylint test.
2017-11-21 23:22:51 -08:00
95a2140f4b
Use show command to support wider platform set for nxos_interface module ( #33037 )
...
* Use show command to support wider platform set
* Fix unit tests
2017-11-20 18:59:09 +00:00
84117e57ba
nxos: 32 bits AS in as-dot format not recognized by regexp asn_regex ( #30569 )
...
* added test for 32 bits AS
* Lint not happy.
2017-11-20 10:09:16 +00:00
208208ab8f
Fix nxos_snmp_host bug ( #32916 )
...
* Fix nxos_snmp_host bug
* Enable nxos_snmp_host tests
2017-11-16 06:17:42 +00:00
e2fef7beed
nxos_facts: cdp support ( #31202 )
...
* nxos_facts get CPD neighbor
* nxos_fact: cdp support
* remove blank spaces
* add ansible_net_neighbors cdp informations
2017-11-15 07:38:19 -07:00
3ee2501c83
multiple fixes nxos ( #32903 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-14 15:23:11 +00:00
c40de24e9c
fix mtu check nxos_interface ( #32880 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-14 10:40:37 +00:00
1360ae6518
nxos_config and nxos_facts - fixes for N35 platform. ( #32762 )
...
* update nxos_facts to handle errors in n35 platform
* switch show commands to output text
* replace basestring which is not supported in python3
* do it like the other modules: use string_types
* incorporate PR review
2017-11-14 05:03:37 +00:00
f49555d494
nxos_bgp_neighbor_af feature idea disable-peer-as-check ( #32665 )
...
* nxos_bgp_neighbor_af feature idea disable-peer-as-check
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-13 14:48:31 +00:00
e4052c1261
Add mtu option nxos_interface feature idea ( #32680 )
...
* Add mtu option nxos_interface feature idea
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add unit test for mtu feature
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-13 14:48:04 +00:00
b0e7c71716
nxos_interface TypeError fix ( #32114 )
...
* nxos_inteface TypeError fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Make sure that run_commands does not list of strings for json output
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* return default value to handle exception
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-13 10:47:20 +00:00
de8d00b401
Fix snmp bugs on Nexus 3500 platform ( #32773 )
...
* Add n35 platform support
* Fix regex bug and add snmp_location it tests
* Enable nxos_snmp_location tests
2017-11-13 08:03:06 +00:00
fedd1779cc
Add ISSU capability and fix workflow bug for nxos_install_os module ( #32540 )
...
* Initial issu support
* Enhance ISSU support
* Additional refactoring to simplify code flow
* Remove debugs and bug fixes
* Update doc example output
* Update provider line in task example
* Remove unneeded else clause and comments
* Fix ansible-doc errors
* Satisfy ansibot requirements
* Update header docs
* Update nxos_install_os.py
2017-11-09 14:54:19 +00:00
7fe69daa4d
Modules metadata: fix invalid GitHub ID in author field ( #31856 )
...
* Replace Twitter username with GitHub ID
See 8bfa19c4af22766906b09c6ee8d0bbe37e736ddbf6a4803669https://github.com/ansible/ansible-modules-core/pull/2880
Not sure how Ansibullbot will handle an organization ID, but
other deprecated modules already use it.
* Replace Twitter username with GitHub ID
* Replace Twitter username with GitHub ID
See bf59d1cc1ed02a9016a2a59684fddd94f9bb962f40b7dffea8
2017-11-02 06:52:18 -04:00
1068aa3ce7
Fixing nxos_vlan to match platform agnostic net_vlan part2 ( #32410 )
...
* adding active and suspend to state to match net_vlan module
although this is backwards compatible (for now)
* removing bad config
* getting rid of bad yml syntax
2017-11-01 14:56:38 +05:30
529b7a7b78
fix nxos_igmp_snooping ( #31688 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-10-23 09:40:07 +05:30
f94ef03625
Fixes #30529 nxos_facts ipv6 interface ( #31286 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-10-16 18:19:44 +05:30
1234a79349
Fix gender pronouns and the odd typo ( #31709 )
2017-10-13 13:52:38 -04:00
046d430a26
Fixes #31056 ( #31057 )
2017-10-13 10:38:44 +05:30
c002b47a79
fix nxos_vlan unexpected deprecation warning ( #31624 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-10-12 12:00:35 +05:30
025386c56b
Fix nxos_banner removal idempotence issue in N1 images ( #31259 )
...
* Fix nxos_banner removal idempotence issue in N1 images
* handle pep8 error
2017-10-11 16:26:17 +05:30
2f8831c787
Fix get_exception and wildcard imports for nxos modules
2017-10-09 21:41:02 -07:00
48f4643a66
nxos_snmp_* fixes : Fixes #30997 , #30999 ( #31000 )
...
* add codeblock to handle 5K platform for nxos_snmp_host
* fix get_snmp_traps for 5K platform
* Make shippable happy
2017-10-06 18:21:59 +05:30
0218fdcd80
Fixes #30846 ( #30862 )
2017-10-06 17:10:03 +05:30
266c2f5831
fixes #31080 ( #31081 )
2017-10-05 14:33:59 +05:30
9f72b32c5d
nxos_config intended_config docfix ( #31337 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-10-05 14:25:50 +05:30
1378861fe7
Fixes nxos_igmp_interface idempotence issue for N1 images ( #31220 )
2017-10-04 12:53:44 +05:30
a12a05c219
Fixes #30769 - nxos_vtp_version errors out on N1 images. ( #30770 )
...
* Fixes #30769
* add the same fix for 2 more vtp modules
2017-10-03 17:24:14 +05:30
916e6be888
- Fix to return error message back to the module. ( #31035 )
2017-09-29 17:06:30 +05:30
879ea24a74
Fix documentation issue for nxos_snmp_user module ( #31029 )
...
* Change auth to authentication in module document
to be in sync with module params
2017-09-28 13:04:20 +05:30
4c21563ac6
- Adds sub-interface support for nxos_interface and nxos_ip_interface ( #30830 )
...
- Support dot1 encapsulation on routed sub-interface
2017-09-26 21:34:51 +05:30
d72eb08902
Fix nxos provider transport warning issue ( #30610 )
...
* Fix nxos provider transport warning issue
* Add default value of transport arg in provider spec
* Remove default value if transport arg in top level spec
This ensure deprecation warning is seen only in case transport
is given as a top level arg in task
* Refactor nxos modules to reference transport value from provider
spec
* Fix unit test
* Remove transport arg assignment in nxos action plugin
* As assigning transport value is handled in provider spec
top level task arg assignment is no longer required
2017-09-22 10:32:25 +05:30
ae044f507f
fix nxos_reboot command format ( #30549 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-20 10:06:57 +05:30
e308176f3e
fix write_on_file nxos_snapshot ( #30545 )
...
* fix write_on_file nxos_snapshot
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* some more logic
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-20 10:06:38 +05:30
7dc60c3f24
nxos_install_os install_state fix
2017-09-15 15:34:32 -04:00
ff84fc969c
Fixes nxos_pim_rp_address module idempotence ( #29620 )
...
* Fixes nxos_pim_rp_address module idempotence
* * Adds a note in header comment to indicate no support for absent state
2017-09-15 14:21:34 -04:00
9af6dc4751
Fix nxos_snmp_community idempotence issue ( #30388 )
...
* Fix nxos_snmp_community idempotence issue
* Use passed in name to filter
* Test updates and remove unused method
2017-09-15 07:45:51 -07:00
173c41aefe
Rel240/fix nxos pim interface ( #29885 )
...
* fix nxos_pim_interface
* Add integration test coverage and fix unit test
* Add clarifying comments
* Make ansibot happy
2017-09-14 13:36:32 -07:00
3faba93a2b
Fix nxos_interface error for nxapi and idempotence problem ( #29136 )
...
* Fix nxos_interface nxapi error and idempotence
* Make shippable happy
2017-09-14 10:25:35 -07:00
37f68bffc0
fixes #27177 - nxos_aaa_server_host multiple issues ( #29103 )
2017-09-14 09:29:53 -07:00
4e32c92166
nxos_udld_interface: improve interface detection ( #28682 )
...
* fix for nxos_udld_interface
* Tested Note added back
2017-09-13 11:06:56 -07:00
8c03609e54
nxos_snmp cleanup ( #28922 )
...
* Clean up nxos_snmp_contact & nxos_snmp_location
* Bring nxos_snmp_community in line
* Bring nxos_snmp_host in line
* And I would have gotten away with it too,
if it weren't for those meddling sanity tests
* Bring nxos_snmp_traps & nxos_snmp_user in line
* Appease Shippable
2017-09-13 08:23:36 -07:00
1a266e29a7
Fixes #28793 , #27484 ( #29745 )
2017-09-13 08:08:22 -07:00
169fbc4c94
Fixes #28493 ( #29061 )
2017-09-13 08:00:13 -07:00
5537218c94
fixes #27066 - nxos_acl errors when there are 0 or 1 access lists configured ( #29076 )
...
* fixes #27066
* replace type() with isinstance()
2017-09-13 18:07:06 +05:30
f1cc5a928c
Fixes #27336 - nxos_gir_profile_management issue while creating profile ( #29151 )
...
* Fixes #27336
* Correct documentation errors
2017-09-13 17:54:35 +05:30
7292dd20ed
Fix nxos_overlay_global networking modules ( #28943 )
2017-09-13 17:33:06 +05:30
bc6e015a86
Fixes #27138 ( #29064 )
2017-09-13 17:11:00 +05:30
578ae3b238
fix nxos_file_copy and provider getting set to None when transport is cli ( #30262 )
...
* nxos_file_copy bug fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* provider gets set to None in module level when transport is cli
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-13 16:36:41 +05:30
442af3744e
Miscellaneous pylint fixes.
...
The following rules are no longer disabled:
- bad-format-string
- duplicate-key
- lost-exception
- trailing-newlines
- unexpected-keyword-arg
- useless-suppression
- using-constant-test
2017-09-13 01:53:08 -07:00
cef7ed0310
Fix nxos_mtu nxapi failure ( #30153 )
2017-09-13 10:51:46 +05:30
f973f93963
Fix nxos_smu error ( #30157 )
2017-09-12 22:17:07 +01:00
5b1c91bf19
nxos_system parse name_servers fix ( #29944 )
...
* nxos_system parse name_servers fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_system tests
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-12 13:25:01 +05:30
588bddbc35
nxos_banner CI fix ( #29134 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-08 19:33:41 +05:30
f84ff216b6
Generalize nxos_bgp event-history detection ( #28890 )
...
* More general handling of event-history
* Update unit tests
2017-09-06 17:37:44 -04:00
8bfdbd0f73
nxos_bgp_neighbor: Fix regex &report warnings ( #28888 )
...
* Fix over-detection of log-neighbor-as
* Report nxos warnings
* Update nxos_bgp_neighbor unit tests to test remove-private-as
2017-09-01 15:17:42 -04:00
fb1aa54341
Rel240/fix nxos interface ospf ( #28898 )
...
* Fixes 28897 nxos_interface_ospf idempotence
* Handle all characters upper or lower with tests
2017-09-01 11:07:18 -04:00
ae6d27fa29
Revert "Bring nxos_snmp_host in line"
...
This reverts commit 43247c8dfe0df77408d79e4cdd2fce
2017-09-01 08:00:00 -04:00
43247c8dfe
Bring nxos_snmp_host in line
2017-09-01 07:43:05 -04:00
0df77408d7
Bring nxos_snmp_community in line
2017-09-01 07:15:24 -04:00
9e4cdd2fce
Clean up nxos_snmp_contact & nxos_snmp_location
2017-09-01 07:12:49 -04:00
07c1d7e1ca
update nxos_facts to handle n3k power table ( #28891 )
...
* handle power table for n3k
2017-08-31 14:59:14 -04:00
74daf2381b
Fix nxos_config `save` parameter ( #28838 )
...
Also fix saving in general
2017-08-31 10:01:19 -04:00
d9fc3def94
Fixes #28779 eth_mode key error ( #28782 )
...
* Fixes #28779 eth_mode key error
* Remove unused get_config references
* Addressed PR comment
2017-08-29 17:07:46 -04:00
64dac346c9
Fix nxos_pim_interface dr-priority handling ( #28472 )
...
* Fix nxos_pim_interface dr-priority handling
* Prefer execute_show over `| json`
* Mock get_config
* Fix sparse-mode detection
2017-08-29 14:42:09 -04:00
2cf836772d
Add passive_interface property to nxos_ospf_vrf module ( #28288 )
...
* add passive_interface property to nxos_ospf_vrf module
* Add version_added for
2017-08-29 11:31:11 -04:00
40907d7db2
Fix detection of associate-vrf parameter ( #28725 )
2017-08-29 09:47:27 -04:00
862cde5e82
[WIP] Fix nxos_banner ( #28607 )
...
* Fix `'state': 'absent'`
* Replace idempotence tests with references
* Fix issues with nxos_banner
2017-08-28 17:09:54 -04:00
0a8ec4ddef
fix nxos_igmp_interface output ( #28735 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-28 17:06:30 -04:00
3d46258cff
Refactor/fix nxos_nxapi to use show run ( #28675 )
...
* Refactor/fix nxos_nxapi to use show run
* Fix unit tests
* Python 3 compatibility
2017-08-28 15:00:56 -04:00
fbeb3b9ac5
Nxos ping ( #28665 )
...
* Update documentation & results, clean up code
* Change numeric results to int/float
2017-08-25 11:45:46 -04:00
ada7f248c0
Add 'Tested on' string to NX-OS modules ( #28531 )
2017-08-24 08:27:39 -04:00
e1def05ba2
fix networking *_command check_mode ( #28407 )
...
* Fix check_mode in nxos_command
* Fix check_mode for ios_command
* fix check_mode for iosxr_command
* Fix check_mode in vyos_command
* Fix check_mode in eos_command
* Fix check_mode in junos_config
2017-08-22 14:02:55 -04:00
96abfde189
Fix idempotence for nxos_vrf_af ( #28419 )
2017-08-22 14:02:01 -04:00
ec11cd2696
nxos_bgp_neighbor_af fix problem with advertise-map properties ( #28413 )
...
* Fix problem with advertise-map properties
* Change limit_to back to run all tests
* Fix unit tests
* Move advertise_map out of get_custom_value
2017-08-21 15:28:02 -04:00
beed59f303
Fix trailing space in ec2_vol example, fix 'the the' typos ( #28440 )
...
* Fix 'the the' typos, fix 'pahting' filename typo
* Change 'the the' typos to a single 'the'.
* Change `playbook_pahting.rst` to `playbook_pathing.rst`.
* Delete trailing space in ec2_vol example
Delete the trailing space in `instance: "{{ item.id }} "`, which makes the
example fail when run because it looks for instance "i-xxxx ".
2017-08-19 23:00:51 +02:00
33f342435a
Attempt to detect and abort when 'fex-fabric' is present ( #28342 )
2017-08-18 16:13:12 -04:00
db5d799122
Fix nxos_pim idempotence ( #28348 )
2017-08-18 09:47:41 -04:00
b818e986b6
Change network *_user modules to use configured_password to set a users password ( #28187 )
...
* WIP, update eos_user args
* refactor password for ios_user
* add eos tests, fix ios tests
* fixed password check
* refactor iosxr_user password
* fixed password arg for nxos
* [WIP] fix vyos_user password
* fix vyos tests
* update docs for net_user
* fix typo
* fix eos tests
* add warning when attempting to use password arg
* fix sanity/unit tests
* fix eos unit tests
* fix vyos_user aggregate
* fix typo in eos documentation string
* re add configured_password to vyos tests after rebase
2017-08-17 19:06:44 +05:30
6886153b54
refactors nxos_vrf_af module ( #28208 )
...
* refactors nxos_vrf_af module
fixes #27595
* fix up unit test cases
* add commands to result dict
* add route-target on afi create
* adds deprecation note to safi argument
2017-08-16 10:11:12 -04:00
d8b1cb9a63
Assign network modules maintained by the network team the network metadata
2017-08-15 23:12:08 -07:00
f203ca7907
Update metadata to 1.1
2017-08-15 23:12:08 -07:00
b7d886840b
standardized agreggate as arg, and collection and users as aliases for user modules ( #28244 )
2017-08-16 09:31:25 +05:30
064ab7a92d
fix for remove idempotent issue ( #28226 )
2017-08-15 13:14:40 -04:00
d69440c4ef
Fix nxos_vpc issues ( #28188 )
...
* fix for nxos_vpc issues
* fix unit tests
* clean documentation
2017-08-15 12:08:55 -04:00
1d13624eae
Clean up nxos_aaa_server ( #28177 )
...
* cleanup nxos_aaa_server
* Specify nxos_aaa_server output format
Fixes #27289
2017-08-15 12:08:03 -04:00
9d84a4e530
fix for nxos_ospf_vrf invalid cmd and ntp errors ( #27977 )
...
* fix for nxos_ospf_vrf invalid cmd
* fix for nxos_ntp issues
2017-08-14 16:09:16 -04:00
19a6000d97
Fix nxos_bgp_af networks parameter ( #28169 )
...
* Split 'networks' and 'redistribute' in get_value
* Add missing `'` in docs
2017-08-14 15:18:10 -04:00
b74300b657
Additional fix for #27167 : port-channel interface idempotence ( #27979 )
2017-08-14 11:44:12 -04:00
820d7e805a
Streamline nxos_smu ( #28030 )
2017-08-14 10:54:50 -04:00
b9c3329950
nxos_ip_interface: Fixes for #27170 , #27172 ( #27935 )
...
* Fixes for #27170 , #27172
* Add nxos_ip_interface IT tests
* For ipv6 check if ip address configured before doing a no ip address
2017-08-14 10:16:08 -04:00
cfda267b2b
fixes pipe issue ( #28127 )
2017-08-14 17:21:32 +05:30
60ce6438e3
fix nxos_overlay_global idempotence ( #28150 )
...
* fix nxos_overlay_global idempotence
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify nxos_overlay_global unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-14 16:09:53 +05:30
a01aa6e9df
Fix structured output not supported in nxos_pim_interface ( #28125 )
...
* fixed unstructured error
* fix unit tests so they accept commands in dictionary form
2017-08-14 12:34:05 +05:30
aef4e3d8fa
fix nxos_snapshot ( #27993 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-11 12:16:37 -04:00
17a259a163
fixes command to be sent over nxapi for nxos_file_copy ( #28029 )
...
fixes #27347
2017-08-11 12:14:52 -04:00
0464a21a85
Fix nxos_snmp_contact, others ( #28000 )
...
* Fix nxos_snmp_contact
Fixes #27714
* Fix nxos_snmp_community
Fixes #27711
* Fix nxos_install_os
Fixes #27604
* Update nxos_ntp_auth
Fixes #27521
* Fix nxos_igmp_snooping
Fixes #27501
2017-08-11 10:12:43 -04:00
d0485779e8
nxos_smu: fix Structured output unsupported error in nxapi ( #27976 )
...
* fixed structured output unsupported error
2017-08-10 14:12:15 -04:00
ed8a5af3dc
nxos_bgp: Fix idempotence for event-history ( #27329 )
...
* Fix idempotence for event-history
* `event-history detail` defaults to `False`, the rest to `size_small`
2017-08-10 08:55:43 -04:00
a78f3faa6c
nxos_bgp_neighbor_af does not want required_together ( #26370 )
...
* nxos_bgp_neighbor_af does not want required_together
* fixup tests
* Fix max_prefix_* issues
* Require address-family
* Fix idempotency for next_hop_third_party
* Fix idempotency for allowas_in*
* Fix idempotency for *_in and *_out
* Reorder command generation again
`default` is first, then `max-prefix`, then booleans
2017-08-09 15:54:34 -04:00
4fb114174b
fixes Traceback generated by nxos_igmp module ( #27869 )
...
* fixes Traceback generated by nxos_igmp module
* update module code to reflect review comments
* doh!...remove q
2017-08-09 15:52:37 -04:00
14186af558
Fix for nxos_ospf idempotent issue ( #27913 )
2017-08-09 11:25:35 -04:00
01dda25e0f
fix nxapi transport in nxos_snmp_location ( #27849 )
...
* fix nxapi transport in nxos_snmp_location
* Appease Shippable
2017-08-09 09:44:02 -04:00
c1bf74283e
Network load_config: Capture configuration output and display as warnings ( #27851 )
...
* Capture configuration output and display as warnings
* Don't break on nxapi
nxapi errors very loudly instead, so no need to muck about with warnings
2017-08-09 09:43:04 -04:00
babec35faa
Fix nxos_vtp_password and nxos_vrf_interface for remove idempotency tests ( #27724 )
...
* fixes for 27600 27676
* add sanity tests
2017-08-08 12:40:22 -04:00
0b67ef4232
fixes #27527 ( #27868 )
2017-08-08 10:12:02 -06:00
441376c754
Fix #26024 : suppress_fib_pending imdepotence for nxos_bgp ( #27862 )
2017-08-07 21:08:46 -04:00
65cf31e1ce
Fix nxos_interface_ospf idempotence issue ( #27783 )
...
* Add tests and fix 27167
* Add modify test
2017-08-07 13:54:31 -04:00
b9e80b6117
nxos_vrf_interface cleanup ( #27642 )
...
* Update RETURN, results, & execute_show_command
2017-08-07 10:57:45 -04:00
edb5760723
nxos_vpc doc update to handle confirmation prompt ( #27796 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-05 11:05:38 +05:30
e0f482a8c5
Fixes #27340 - make indent consistent for nxos_config ( #27652 )
2017-08-03 07:09:31 -04:00
123b5e222f
nxos_bgp_neighbor fixes ( #27348 )
...
* Fix `timers` idempotency
* `shutdown` is not documented as having a `default` option
* dynamic_capability is the inverse of BOOL_PARAMS
2017-08-02 11:07:46 -04:00
b93878b685
Minor cleanup to nxos_vrrp ( #27593 )
...
* Safe changes
* Fold `[0]` into `execute_show_command()`
We only ever execute one command, so only return the one response
* Streamline `results`
2017-08-02 08:46:44 -04:00
37392318a6
fix nxos_vlan and nxos_switchport issues ( #27505 )
2017-08-01 16:27:12 -04:00
407dc2dc68
fix nxos_vrf removal failure ( #27547 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-01 11:51:25 -06:00
d7202e6155
Add fabricpath support for nxos_vlan ( #26013 )
...
* Add files via upload
Fix for issue #25720
* nxos_vlan fabricpath (#25720 )
Fix for issue #25720
* Add files via upload
* Add files via upload
* Delete nxos_vlan.py
* Add files via upload
* Add files via upload
2017-08-01 11:27:47 -06:00
350018de73
nxos_vxlan_vtep fixes and integration tests ( #27405 )
...
* fix issue 27404
* conflict resolve
2017-07-31 08:37:31 -04:00
07b097af7c
Fix nxos portchannel force option ( #27190 )
...
* Add integration tests
* Fix force option
* Enable nxos_portchannel test
* Satisfy ansibot demands
2017-07-28 13:06:41 -04:00
fb2b3de5e4
Fix nxos_vtep_vni typo
2017-07-28 13:04:08 -04:00
a49c419651
fix nxos_vrf_af nxapi & cli ( #27307 )
...
* fix nxapi failure #27142
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_vrf_af nxapi and cli
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-28 09:02:02 +05:30
81151ef02c
Remove Deprecated Template network modules ( #27076 )
...
* removed deprecated networking template modules
* update changelog
* update changelog
2017-07-27 19:40:11 +01:00
7351ee9a76
fix nxos_interface multiple issues ( #27106 )
...
* fix execute_show_command
* fix pep8 issues
* fix AttributeError #26562
* legacy-file remove
* modify execute_show_command output
* fix admin_state up doc
* fix admin_state for all interfaces doc
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-27 19:23:35 +05:30
9b9a8749da
Add integration tests and fix nxos providers ( #26913 )
...
* fix issues with python3.x
* Add integration testa and fix for nxos_evpn_vni
* add nxos_evpn_vni to nxos.yaml
* fix get_vtp_config()
* add new integration tests
* fix rollback
* add integration test files
2017-07-27 09:32:35 -04:00
2eaf3571f3
fix state absent nxos_hsrp ( #27366 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-27 14:28:46 +05:30
8643e9cb34
changed collection arg to argregate on 2.4 network modules ( #26649 )
...
* changed collection arg to argregate on 2.4 network modules
* replace users with aggregate in eos_user, junos_user, nxos_user
* added version_added to places where we replaced users with aggregate in the docs
* fix ios_static_route test
* update tests to reference aggregate instead of collection/users
2017-07-26 10:09:17 -04:00
41ce724801
fix nxos_hsrp ( #27306 )
...
* fix nxos_hsrp
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify nxos_hsrp test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-26 11:38:55 +05:30
225fa5d092
Fix undefined variables, basestring usage, and some associated python3 issues
2017-07-25 15:58:23 -07:00
8b34e31e05
Remove the error checking from apply_patch()
...
The error checking would itself cause a traceback. The load_config()
function that we'd need to check for errors from only returns None so
there's no way to check for errors via the return value. In the future
someone could rewrite the load_config function to return useful
information and restore the error checking but for now this is better as
it won't traceback on success and it will let us turn on static analysis
of undefined variables
Fixes #27255
References #27254
2017-07-25 06:12:44 -07:00
e37e736ddb
nxos_logging implementation module ( #26949 )
...
* nxos_logging implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* pep8 fixes
* nxos_logging integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* test typo fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* idempotent fix
* rename feature to facility
* make dest_group global var
* remove str from arg_spec
2017-07-25 17:03:54 +05:30
85e7e342b0
nxos_bgp_af correct parents ( #26996 )
...
* move config location
* client-to-client is inverse of BOOL_PARAMS
2017-07-20 13:42:26 -04:00
56a0b988a9
nxos integration fix part 1 ( #27069 )
...
* Assorted Python 3 fixes
* Fix `testcase` definition in integration tests
* Fix nxos_acl_interface
* clean up nxapi after nxos_nxapi
2017-07-19 14:00:05 -04:00
a3aa5d799e
Fix nxos_system name-server parsing ( #25973 )
...
* Fix nxos_system name-server parsing
* Introduce lookup_source as a noop, but don't advertise its use
2017-07-17 11:15:43 -04:00
855544604a
Fix nxos_bgp_neighbor_af advertise_map and advertise_map_non_exist ( #26721 )
2017-07-17 11:15:06 -04:00
61249995a1
Update nxos_interface_ospf & add test ( #26644 )
...
* Update nxos_interface_ospf & add test
2017-07-14 12:31:36 -04:00
b9a1998af5
changes `changed` to `modified` in save_when choices ( #26801 )
2017-07-14 15:08:19 +02:00
62e4353ba1
nxos_facts cleanup ( #26192 )
2017-07-13 16:56:04 -04:00
5cfdd5df0f
nxos_pim_interface ( #26367 )
...
* Add unit tests to nxos_pim_interface
* Update tests to match module
* Update nxos_pim_interface
* Address pep8 issues
2017-07-12 15:39:43 -04:00
63fe40c691
fixes issue when creating instance of NetworkConfig ( #26665 )
2017-07-11 21:28:35 -04:00
0b6f0e6c0d
adds more intelligent save logic and diff to network config modules ( #26565 )
...
* adds more intelligent save logic and diff to network config modules
* adds sha1 property to NetworkConfig
* adds new argument save_when to argument_spec
* adds new argument diff_against to argument_spec
* adds new argument intended_config to argument_spec
* renames config argument to running_config with alias to config
* deprecates the use of the save argument
* before and after now work with src argument
* misc module clean
Modules updated
* nxos_config
* ios_config
* eos_config
Most notably this makes the save mechanism more intelligent for config
modules for devices that need to copy the ephemeral config to
non-volatile storage.
The diff_against argument allows the playbook task to control what the
device's running-config is diff'ed against. By default it will return
the diff of the startup-config.
* removes ios_config from pep8/legacy_files.txt
* extends the ignore lines argument to the module
* clean up CI errors
* add missing list brackets
* fixes typo
* fixes unit test cases
* remove last line break when returning config contents
* encode config string to bytes before hashing
* fix typo
* addresses feedback in PR
* update unit test cases
2017-07-11 20:34:20 -04:00
07498ebed3
fix nxos_overlay_global ( #26422 )
...
* fix nxos_overlay_global
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* swap check_mode with candidate
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-10 18:53:52 +05:30
c5fb4bbcc0
Fix nxos_switchport and unit test ( #26131 )
...
* fix nxos_switchport
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_switchport unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* legacy file
* update unit test
* handle exception
2017-07-06 18:58:36 +05:30
5229370364
fix for nxos_acl_interface idempotency ( #26156 )
...
* fix for nxos_acl_interface idempotency
* shippable error fix
* fix issues with python3.x
2017-07-05 12:05:47 -04:00
240de965ee
Fix nxos_acl module and add IT tests ( #25966 )
...
* Fix nxos_acl module and add IT tests
* Add nxos_acl test
* Add additional properties to test
2017-06-29 14:55:08 -04:00
3102746ebe
nxos_pim_rp_address fixes ( #26119 )
...
* nxos_pim_rp_address tests
* nxos_pim_rp_address changes
* Address issues with idempotence
2017-06-29 10:22:26 -04:00
ad6c4a544e
nxos_pim updates ( #26145 )
...
* nxos_pim tests
* Cleanup nxos_pim
2017-06-28 19:40:19 -04:00
eea18e9875
nxos_vxlan_vtep_vni fixes ( #25913 )
...
* nxos_vxlan_vtep_vni first pass
* nxos_vxlan_vtep_vni tests
2017-06-28 19:38:31 -04:00
21c7fcf9c0
nxos_vxlan_vtep ( #25971 )
...
* nxos_vxlan_vtep tests
* Fix issues with nxos_vxlan_vtep
2017-06-24 14:09:11 -04:00
3482a6326b
Fixes nxos_vpc_interface ( #25907 )
...
* nxos_vpc_interface fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_vpc_interface unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix state_present
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add state_present unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* make ansibot happy
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* teardown get_config
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-24 18:05:07 +05:30
0296c2285b
nxos_vrf fix ( #25812 )
...
* Fixes #25031
* Slight cleanup and add tests
2017-06-20 10:59:03 -04:00
450263e934
Add junos_banner declartive module ( #25826 )
...
* Add junos_banner declartive module
* junos_banner implementation
* Integration test for junos_banner
* Integration test for net_banner (junos)
* Minor fixes
* Minor doc change
2017-06-18 01:32:48 +05:30
a38e727380
nxos_nxapi fix ( #25306 )
...
* Add nxos_nxapi tests
* Simple changes to nxos_nxapi
* Move validation to check_args
* Don't mark protocol change unless change is requested
* Add different regex to handle HTTP{,S} ports on a different version of nxos
2017-06-16 07:15:08 -06:00
9c6ee8d0bb
Add nxos_banner implementation module ( #25695 )
...
* Add nxos_banner implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_banner integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_banner unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* doc update
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-15 22:05:38 +05:30
4344132a7d
nxos_vpc updates ( #25452 )
...
* Add nxos_vpc tests
* Split execute-show between get_config and run_commands
2017-06-14 11:06:49 -04:00
b76acc8ce8
Fix nxos_vpc idempotence issues ( #25219 )
...
* Fix nxos_vpc idempotence issues
* Remove legacy-file pep8 now passing
2017-06-07 10:35:08 -04:00
f6a4803669
New module: platform agnostic way to manage local users on network devices (network/net_user.) ( #25259 )
...
* Add net_user platform agnostic module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Integration test for net_user
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify eos_user module to support name param as alias to username
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Test collection of users
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-06 20:05:08 +05:30
343b83041e
nxos_feature fix and unit test ( #25200 )
...
* nxos_feature fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_feature unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove from pep8/legacy-file
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-01 08:58:35 +05:30
fb87680046
fix state present nxos_evpn_vni ( #25212 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-01 08:57:17 +05:30
53837c2ab0
Assorted nxos_bgp_* fixes ( #25080 )
...
* Simplify apply_key_map
* Fix nxapi
* Clean up get_value
* Fix missing non-values
* Add test for existing bgp_af case
* Fix small issues with bgp_neighbor_af
2017-05-30 14:11:15 -04:00
31c59ad5f9
nxos_portchannel fix and unit test ( #25019 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-30 21:22:24 +05:30
8985f7c930
nxos_static_route updates ( #24992 )
...
* Add static_route tests
* Add VRF tests
2017-05-25 12:19:04 -04:00
307fd1b3dc
nxos_vlan fix ( #24973 )
2017-05-25 09:45:43 +05:30
dd4a79d7d3
Clean up nxos_bgp_neighbor_af ( #24890 )
...
* Fix pep8 in bgp_neighbor_af
* Remove WARNINGS
* Rewrite command detection
* Add bgp_neighbor_af test
* Finally kill invoke
2017-05-23 12:43:55 -04:00
4066b03a4c
nxos_evpn_global refactor ( #24919 )
...
* nxos_evpn_global refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot told me to do this
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-23 14:54:54 +05:30
b12beca3ed
Refactos nxos_ip_interface module ( #24885 )
2017-05-22 19:48:59 +02:00
1e5a0982b9
Fix nxos_hsrp and add unit test ( #24770 )
...
* nxos_hsrp fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unit test nxos_hsrp
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot told me to do this
* revert apply_key_map and simplify method
2017-05-19 10:40:42 -06:00
4782a4e62f
Make host required field and minor refactor ( #24534 )
...
* Make host required field and minor refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot pep8 legacy file
* example doc update
2017-05-19 10:37:01 -06:00
21e28a431b
Remove unused method from nxos_ospf ( #24820 )
2017-05-19 10:57:16 +05:30
998305a493
nxos_ospf_vrf fix and unittest ( #24495 )
2017-05-19 10:09:46 +05:30
8937246f8f
Fix nxos ospf and Unit test ( #24613 )
...
* nxos_ospf fixes refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unit test nxos_ospf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-17 11:16:41 +05:30
f240ba6b60
nxos_bgp_neighbor cleanup ( #24446 )
2017-05-16 10:14:10 -04:00
62b8813873
Improving nxos_ip_interface module ( #21353 )
...
* Improving of nxos_ip_interface module
Added features:
* Route tags for an IP address at interface level with 'tag' option
* Support of IPv4 secondary addresses if option 'allow_secondary' is
true (false by default). If option 'allow_secondary' is true primary
IPv4 address will be replaced
All features support NXAPI and CLI transport, but only with text/raw
output. Currently not possible to get route tags for secondary IPv4/IPv6
addresses from JSON output.
Other changes:
* Module return state 'changed' only when configuration commands were
executed
* Module result includes multiple prefixes if IPv4 addresses were
found
* Fix PEP8 issues
* Addition fix of PEP8 issues
* Remove unused variable from main()
* Fix "proposed" sample in RETURN variable
* Fix "existing" sample in RETURN variable
* Update RETURN variable
Add 'secondary' for every element of 'addresses' list.
* Restore old version number
* Added exception when ipaddress module is imported
* DOCUMENTATION string was updated
* Added 'version_added' for new features
* Added 'requirements' for module
* Added compatibility with latest commit in devel branch
* DOCUMENTATION was fixed
* Improve changes of route tag for existing ip addresses
* Added compatibility with core code
* Fixed mistypes in the DOCUMENTATION variable
* argument_spec fixed
allow_secondary argument type was changed according to allowed choices.
2017-05-12 11:45:44 -04:00
78ed0cadea
Fixing nxos_ntp ( #20651 )
...
* Fixing nxos_ntp
* Fixing style issues
2017-05-12 11:36:44 -04:00
3d51081a59
Refactor nxos_reboot module ( #24484 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-11 13:14:31 +05:30
b2a2f69a6e
nxos_vrf_af fix and unit test ( #24399 )
...
* nxos_vrf_af fix and unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot told me to do this
* use sorted() as the test list elements differ in order for python2.x and 3.x
2017-05-11 10:54:47 +05:30
62eafa8837
fixes nxos_evpn_vni and unittest ( #24372 )
...
* fixes nxos_evpn_vni
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fixes pep8 issue and syntax error
* ansibot tole me to do this
* Unit test
2017-05-11 10:54:05 +05:30
09b2964dee
nxos_bgp_af updates ( #24171 )
...
* update docs
* clean up nxos-bgp_af
* Remove useless params from bgp_af
* Add bgp_af tests
2017-05-10 16:12:00 -04:00
2f26c5285a
Refactor nxos_file_copy module ( #24314 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-10 22:15:42 +05:30
830f19d444
nxos_bgp updates ( #24270 )
...
* Remove invoke from nxos_bgp
* Try to simplify get_existing
* Streamline state_present
* More testing, squash & compact get_value & get_custom_value
* Streamline main
* nxapi has problems reading CustomNetworkConfig directly
2017-05-08 11:38:50 -04:00
ad0a01ffb5
nxos_vrf refactor ( #24280 )
...
* nxos_vrf refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Unit test for nxos_vrf
Remove unnecessary keys() method
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-05 15:38:30 +05:30
986765312f
Fixes #23948 body not defined nxos_hsrp ( #24093 )
2017-05-05 08:36:00 +05:30
67bd8f9204
fixes nxos_interface ( #24199 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-05 08:35:16 +05:30
dce2d5eea9
Remove `provider` requirement from nxos_vrf ( #24118 )
...
Fixes #23920
2017-05-01 09:32:53 -04:00
3d4523f231
Correct RETURN data types for Network modules ( #24104 )
...
`path` isn't a datatype
2017-04-28 12:15:18 +01:00
bc22223d63
Fixes #23890 Remove idle ShellError exception and get_exception() method from nxos modules ( #23947 )
...
Remove idle ShellError exception and get_exception() method from nxos modules
2017-04-28 10:42:15 +05:30
2741907cba
Refactor nxos_interface and add unit test ( #24008 )
...
* [WIP] Refactor nxos_interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Modification in refactor
Unittest for nxos_interface
2017-04-27 21:19:10 +05:30
0d67a49d5a
nxos_bgp fixes ( #23927 )
...
* Pre-emptively fix sanity/pep8
* fix for commands
* Quick unit test
2017-04-26 16:33:54 -04:00
c0ebdf144d
nxos_acl_interface fixes ( #23917 )
...
* Update nxos_acl_interface
* Add basic unit tests to nxos_acl_interface
2017-04-26 16:32:36 -04:00
f0914ee3c2
nxos_acl fixes ( #23915 )
...
* Update nxos_acl
* unit tests for nxos_acl
* Remove nxos_acl from pep8-legacy
2017-04-26 16:29:53 -04:00
0b4cebfb8b
nxos_vlan tweaks ( #23194 )
...
* Remove commented code
Remove a lot of unnecessary output
* Tests
* Sort vlan ids _after_ running set operations, so order is not lost
2017-04-18 10:49:47 -04:00
e1dcc01d3a
pep8 fix for Shippable
2017-04-17 13:18:34 -04:00
bbb9f3164c
Nxos vxlan vtep vni netcfg fix ( #23620 )
...
* Code cleanup
Removed 'add' method from CustomNetworkConfig. It is identical
to the one inherited from NetworkConfig
* Removed unused CustomNetworkConfig import
* Replaced
```
def get_existing(module, args):
existing = {}
netcfg = get_config(module)
config = netcfg.get_section(parents)
```
with
```
netcfg = CustomNetworkConfig(indent=2, contents=get_config(module))
```
get_config returns a string, not an object in 2.3.
* Removed non-functioning get_object method in CustomNetworkConfig in favor of the
inherited method.
Added child_objs property so that expand_selection would work. The original
verion never worked correctly as it compared NetworkConfig obj's and str's.
* Removed ShellError method in favor or new load_config method.
* Removed ShellError method in favor or new load_config method.
fixes #20260
* nxos requires a "no" statement to change mcase group. Corrected.
Corrected changed logic.
* Corrected deleted CustomNetworkConfig import
2017-04-17 12:40:13 -04:00
e518b6f5b4
Clean up import statements for nxos_rollback ( #23540 )
...
* Clean up import statements for nxos_rollback
* Don't try to deal with pre-2.3 logic
2017-04-17 08:51:38 -04:00
2bb25d031b
network_cli modules don't always return stdout or stdout_lines ( #23573 )
...
It's possible that if the module has a low-level failure, such as
"unable to open shell", or something else in the action plugin that
stdout and stdout_lines will not be returned.
Update the documentation to clarify this point.
2017-04-13 11:59:23 -04:00
902bc58509
[WIP] Network return docs ( #23441 )
...
Network return docs
2017-04-12 13:13:41 -04:00
98c23a3342
Attempt to clear up nxos_mtu tests and documentation ( #23361 )
...
nxos_system wasn't added until 2.3, so nxos_mtu should have been deprecated
then.
2017-04-06 12:26:17 -04:00
d890167575
Fix nxos_facts for nxapi transport ( #23302 )
...
* Partial revert of 2e476e64cd
2017-04-05 11:47:37 -04:00
2e476e64cd
fixes error parsing lldp neighbors when running nxos_facts ( #23134 )
2017-03-30 11:30:50 -04:00
9b2bdf2df6
Fixing module behavior when route_target_both is used ( #20076 )
2017-03-25 08:02:15 -04:00
d7d76f3aaf
Fixing nxos_vrf_interface when interface name is not full ( #22769 )
2017-03-23 22:57:24 -04:00
866f67e213
fixes a number of issues with nxos_facts ( #22923 )
...
* updates command runs to return warning if command fails
* fixes variable issues from recent refactoring
* removes provider from return of module
2017-03-23 22:35:15 -04:00
02f66b9369
E1 legacy pep8 fixes ( #21933 )
...
* E1 pep8 fixes
* e111 fix for rds.py
2017-03-21 21:19:40 -05:00
08d9a5932f
metadata_version
2017-03-15 17:28:52 +00:00
f82239e1f7
[WIP] Network module docs 2.3 ( #22454 )
...
* Tidy up docs for network 2.3 modules
* Use suboptions
* Correct indentation
* more tidyup
* bulk updates
* more tidyup
* Bulk changes
* nxos_mtu is dead
* revert
* NXOS_mtu is dead, also better layout
* rebase
* rebase
2017-03-15 16:00:43 +00:00
eb1214baad
New metadata 1.0 ( #22587 )
...
Changes to the metadata format were approved here:
https://github.com/ansible/proposals/issues/54
* Update documentation to the new metadata format
* Changes to metadata-tool to account for new metadata
* Add GPL license header
* Add upgrade subcommand to upgrade metadata version
* Change default metadata to the new format
* Fix exclusion of non-modules from the metadata report
* Fix ansible-doc for new module metadata
* Exclude metadata version from ansible-doc output
* Fix website docs generation for the new metadata
* Update metadata schema in valiate-modules test
* Update the metadata in all modules to the new version
2017-03-14 09:07:22 -07:00
aa3fbb0d54
Restore extends_documentation_fragment: nxos ( #22312 )
...
* Restore extends_documentation_fragment: nxos
* Restore extends_documentation_fragment: nxos
2017-03-06 13:53:33 +00:00
8d76703a9d
fix for handling commands that return no data or error ( #22086 )
...
This patch addresses a problem in nxos_facts where certain commands are
not supported or return no data, the module would raise an exception.
With this patch, the nxos_facts module will now print a warning for any
commands that return no data and not populate the facts.
fixes #22001
2017-03-02 16:02:16 -06:00
c26cac2a53
catches exception in nxos_command and returns failed message ( #22151 )
...
Catches exception in Conditional check and returns appropriated failed
message
2017-03-01 12:41:31 -05:00
ebc2716be7
removes old module.connected property from result ( #21977 )
2017-02-26 23:14:56 -05:00
216877c6ca
adds system_mtu argument to nxos_system ( #21970 )
...
* updates argument_spec
* adds unit test case
2017-02-26 11:33:58 -05:00
Trishna Guha
saichint
John R Barker
Matt Clay
Nathaniel Case
Pilou
Ganesh Nalawade
bdowling
rahushen
Abhijeet Kasurde
Mike Wiebe
Arnaud
chifu1234
Sean Cavanaugh
Kenny Gillen
Toshio Kuratomi
Kedar K
Nathaniel Case
David Kretch
David Newswanger
Peter Sprygada
Dennis Israelsson
Ricardo Carrillo Cruz
Ilya Drey
Gabriele
Daniel
Matt Martz