Commit Graph

72 Commits (8d203225d35d1db952bfee89ad72572bc96fe845)

Author SHA1 Message Date
Florian Apolloner 8d203225d3
Fixed mysql_user idempotency for long privilege lists. (Fixes ansible/#68044) (#58) 2020-04-01 17:31:53 +02:00
Abhijeet Kasurde d921968504
homebrew: Add info about changed packages (#31)
homebrew now returns details about changed and unchanged packages
after performing the operations.

Fixes: ansible/ansible#59376

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-04-01 17:32:25 +05:30
Abhijeet Kasurde de0409e793
ipa: Remove redundant encoding in json.loads (#87)
Fixes: ansible/ansible#66592

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-04-01 17:09:38 +05:30
Ruheena Ansari 07e8911fd8
Update docker connection plugin (#80)
* Update docker.py

#67832 fixes the need to run powershell modules on windows containers via docker connection. However, while running win_copy on windows containers, destination path is prefixed, which doesn't work in the case of windows. The changes in this PR take care of bypassing that while running the ansible role on windows containers.

* Update plugins/connection/docker.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Create 80-update_docker_connection_plugin.yml

Add changelog fragment

* Update changelogs/fragments/80-update_docker_connection_plugin.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-03-31 20:42:16 +02:00
René Moser 0205adef24
cloudstack: ci: wait for sys template available (#78)
* cloudstack: ci: wait for sys template available

* gather all templates

* smoke test VM
2020-03-31 16:08:51 +02:00
Felix Fontein 74d83d8e94
supervisorctl tests: shorten path to .sock file to make OSX happy. (#77) 2020-03-31 10:52:24 +02:00
Felix Fontein e92f288d5b
Add changelog fragments for #17, #18, #19, #24, #26, #36, #37, #39. (#74) 2020-03-31 09:50:48 +01:00
Felix Fontein be191cce6c
Move modules and module_utils unit tests to correct place (#81)
* Move modules and module_utils unit tests to correct place.

* Update ignore.txt

* Fix imports.

* Fix typos.

* Fix more typos.
2020-03-31 10:42:38 +02:00
Felix Fontein ab3c2120fb
Fix sanity test failures for _netapp.py. (#82) 2020-03-31 10:27:23 +02:00
Felix Fontein 6172e56b62
Fix netapp modules (#76)
* Replace missing netapp parts with own copy.

* Localize final fragment.

* Mark netapps docs fragment as deprecated.

* Drop dependency on netapp.ontap.

* Remove all netapp_e_* modules.

* Remove docs fragment.
2020-03-31 09:41:29 +02:00
Abhijeet Kasurde 50f8477dbc
rhn_channel: Add validate_certs parameter (#79)
Provide parameter to override HTTPS verification.

Fixes: ansible/ansible#68374

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-03-31 08:47:20 +02:00
Abhijeet Kasurde 273a678771
homebrew_cask: Follow up changes (#32)
Follow up changes recommended in code review

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-03-30 19:15:17 +02:00
Felix Fontein 0026c9f5b2
Fix become plugins (#50)
* Fix become plugins.

* Fix become unit tests to avoid play_context.make_become_cmd.

* Remove hack.

* Remove explicit defaults. Adjust tests to be more like Ansible itself.

* Forgot two lines.

* Rewrite tests (again).

* Rename play_context -> task, add possibility to pass var_options.

* Add var_options variants.

* Properly test overwriting.
2020-03-30 19:09:45 +02:00
Felix Fontein 7d8ca8bdbb
Revert "Don't run CI on Master (#73)" (#75)
This reverts commit f2418d343d.
2020-03-30 14:20:04 +02:00
Felix Fontein 6632c87bb0
Add folder for changelog fragments. (#72) 2020-03-30 12:49:40 +02:00
John R Barker f2418d343d
Don't run CI on Master (#73)
We are blocking CI too much.
2020-03-30 11:38:21 +01:00
Felix Fontein 2cb3605617
Use ansible/ansible#68550 instead of devel branch of Ansible to prevent full CI runs for docs/ and changelogs/ changes. (#71) 2020-03-30 12:24:45 +02:00
Abhijeet Kasurde cc2b1e7b6d
influxdb_user: Don't grant admin privilege in check mode (#26)
influxdb_user module don't change the admin flag for existing
user

Fixes: ansible/ansible#68139

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-03-30 15:38:50 +05:30
Felix Fontein 027ffcae56
Fix more tests (#66)
* Fix permissions.

* Fix more FQCNs.

* Adjust more ansible_pkg_mgr usages.

* Fix plugin FQCN.

* Change port 12345 -> 12347.

* Print port usage first.

* Support both short and long name.

* Revert "Print port usage first."

This reverts commit ea1dbc60f08a2664a8b01abba7aa7610bc2a23f1.

* Revert "Change port 12345 -> 12347."

This reverts commit cbc13510ee9f855110b4134517b2a548745a1fb0.

* Fix cleanup.

* Add more FQCNs.

* Allow short name as well.

ci_complete

* Add remaining ignore.txt entries for ipaddress.

* Remove kubevirt ignore.txt entries.

* Added missing entries, and sorted.

* Remove superfluous fact gathering.

* Fix FQCNs.

* Temporarily disable supervisorctl (fails on OSX because socket path is too long)

* Add missing file.

* Fix permissions.

ci_complete
2020-03-30 11:06:48 +02:00
Felix Fontein 14731bf485
Fix even more tests (#69)
* Remove meraki unit tests.

* Reenable disabled tests.

* Re-disable xfs_quota tests - depend on ansible/ansible#68223.

* Fix FQCNs.

* More FQCNs.

* Fix typo.
2020-03-30 08:24:27 +01:00
Felix Fontein 775ab35ddd
Set pkg_mgr facts manually for FreeBSD and OpenSUSE (#60)
* Set pkg_mgr facts manually for FreeBSD and OpenSUSE.

ci_complete

* Make pkg_mgr fact work everywhere.
2020-03-29 21:34:10 +02:00
Felix Fontein 8c76619799
Fix docker_swarm, docker_machine and gitlab_runners inventory plugins' verify method. (#67) 2020-03-29 20:14:22 +02:00
Felix Fontein 897c6ad0f2
Remove patch tests. (#65) 2020-03-29 13:32:09 +02:00
Felix Fontein 6ab9f071c6
Fix FQCRs. (#64) 2020-03-29 13:02:28 +02:00
Felix Fontein 3c4e98cce2
Fix retry on shippable setup. (#61) 2020-03-29 11:20:29 +02:00
Felix Fontein 66267a50b3
Forgot entry in ignore.txt for module_utils/compat/ipaddress.py (#62) 2020-03-29 11:19:16 +02:00
Jesse Pretorius 67bea39474
Remove residual rabbitmq integration test targets (#59)
In [a] These should have been removed, but they weren't.

[a] https://github.com/ansible-collections/community.general/pull/13
2020-03-28 19:34:40 +00:00
Abhijeet Kasurde c874089d1d
homebrew: Add upgrade_options in upgrade_all (#24)
Handle upgrade options in upgrade_all state in homebrew module.

Fixes: #54541

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-03-27 10:11:27 +00:00
Egor Zaitsev 4fba692c1b
routeros_facts: fix crash when ipv6 is disabled (#39)
* routeros_facts: fix crash when ipv6 is disabled

* chore: rename fixture file
2020-03-27 07:10:42 +00:00
Abhijeet Kasurde 5c372e0a7c
homebrew_tap: Doc fixes (#37)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-03-26 20:45:21 +00:00
Felix Fontein 01ae744aa6
Add copy of ipaddress.py from ansible.netcommon (#49)
* Add copy of ipaddress.py from ansible.netcommon, use that one in non-network modules.

* Copy required functions from ansible.netcommon. Simpler than using compat.ipaddress to do this.
2020-03-26 20:44:26 +00:00
Konstantin Gribov f799aa8356
Fix example since lookup/query is not filter (#55)
See also ansible/ansible#68478
2020-03-26 13:24:06 +00:00
Felix Fontein 76880e2403
Fix more plugin unit tests. (#51) 2020-03-25 22:37:34 +00:00
John R Barker a5627744f1
galaxy.yml - Do not add anymore dependencies (#48)
We really don't want any more run-time dependencies adding to `community.general`, so lets document that

I will go through remove as many of these as we can.
2020-03-25 19:28:15 +00:00
Felix Fontein 7fa0c20d5d
Run commands which fetch stuff over network for CI setup up to three times. (#47) 2020-03-25 16:59:11 +00:00
John R Barker eb7d3b2273
Delete tower.sh (#45)
No longer needed
2020-03-25 13:11:52 +00:00
John R Barker 32a90e59ac
Remove unused Tower tests from Shippable (#44)
community.general doesn' have any Ansible Tower tests, so remove them
2020-03-25 11:48:35 +00:00
Andrew Klychkov 1c550cd4ef
postgres: make interfaces of exec_sql clearer (#43)
(cherry picked from commit fb6583a15c1f7fd8e48f4f3ef214ed4e74c3d8c6)
2020-03-25 11:44:28 +00:00
Felix Fontein 07ecfc940c
Fix imports, part 2 (#42)
* Recover missing netapp.ontap module doc fragments from ansible/ansible@pre-ansible-base.

* Fix PEP8 issues.

* Remove netbox empty files, and test which shouldn't be here.

* Add forgotten file for kubevirt tests.

* Fix unit test imports.

* ansible/ansible#68415 has been fixed.

* Clean up/rearrange imports.

* Update ignore.txt, fix boilerplate.

* Netapp docs fragment: fix spacing

* Forgot to adjust kubevirt tests.
2020-03-25 11:43:51 +00:00
Felix Fontein 25394eeafb
Fix imports and installing dependencies in CI, part 1 (#41)
* Fix ovirt collection name (ovirt.ovirt_collection, not ovirt.ovirt).

* Fix kubernetes module_utils references.

* Fix broken f5 imports on community.general side. The imports in that collection are still broken and will still cause failures.

* Fix Cisco ACI and MSO modules imports.

* Fix check_point.mgmt dependency, fix imports.

* Fix fortimanager imports.

* Fix cisco intersight imports.

* Fix ovirt module docs fragments.

* Fix usage of _ in unit tests to avoid sanity failures.

* Fix Cisco module docs fragments.

* Fix netapp.ontap module docs fragment name.

* Fix documentation.

* Fix some boilerplate (the ones not mentioned in ignore.txt).
2020-03-24 22:14:53 +00:00
Felix Fontein 927d91f35f
Fix unit test paths in tests/utils/shippable/units.sh, removing fallaxy targets (#40)
* Fix unit test paths.

* Remove fallaxy targets.

* Remove unit test group 3.

* Avoid sanity tests to fail because they validate something in tests/utils/.
2020-03-24 22:12:55 +00:00
Felix Fontein a91ebb4e97
[WIP] Removed windows dep and unify shippable.sh (#38)
* Removed windows dep and unify shippable.sh

* Removed uneeded -p

* Fix chmod.

* Update tests/utils/shippable/shippable.sh

Co-Authored-By: John R Barker <john@johnrbarker.com>

* Distribute sanity tests into groups.

* Remove docs-build test, which doesn't yet exist for collections.

* Remove package-data.

* Remove unsupported option.

* Fix paths.

Co-authored-by: Jordan Borean <jborean93@gmail.com>
Co-authored-by: John R Barker <john@johnrbarker.com>
2020-03-24 16:09:30 +00:00
Abhijeet Kasurde 7ead1c14fc
homebrew: Doc fixes (#36)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-03-24 08:29:03 +00:00
John R Barker 0a710c2a03
CI should use devel (#33)
* CI should use devel

* Update shippable.sh
2020-03-24 08:27:57 +00:00
Felix Fontein c012d0fba7
Fix unit test relative imports, and permissions for included collection requirements (#29)
* Fix Hetzner firewall unit test imports.

* Make sure tests can actually access collections.

* Fix more relative imports.

* Fix more relative imports.

* Fix more includes.

* Fix more tests.

* One more.

* Fix syntax error in sanity import tests (invalid escape sequence "\$" caused by non-raw docs block)

* Fix permissions of ansible-test parts for sanity tests.

* Revert "Fix permissions of ansible-test parts for sanity tests."

This reverts commit c2713f0a12.
2020-03-24 08:27:28 +00:00
CWollinger 676bec5484
use module required_if so if statements not needed (#28)
Co-authored-by: cwollinger <cwollinger@localhost.localdomain>
2020-03-23 14:41:49 +00:00
Andrew Klychkov 76e72c44cd
postgresql_info: remove unnecessary spaces (#30) 2020-03-23 12:51:13 +00:00
Felix Fontein 7e60763ab3
Fix unit test imports. (#27) 2020-03-22 18:59:18 +00:00
John R Barker 344b48c2bf
ignore-2.10 action plugins (#25) 2020-03-20 17:44:31 +00:00
John R Barker bbc96ebb99
ignore.txt: timing.py 2020-03-19 16:39:07 +00:00