Commit Graph

193 Commits (98343993eeed4995bb96da881c6f8c65a0fdb1b1)

Author SHA1 Message Date
Ruben Tsirunyan 0df453bb5d Zabbix action: Correcting 'notify_all_involved' for acknowledge operations (#53197) 2019-03-03 04:23:22 -05:00
Ruben Tsirunyan befd5b2ff7 Zabbix action: Adding operation condition (#53173) 2019-03-01 11:14:06 -05:00
Ruben Tsirunyan 832a669104 [zabbix_action] Refactoring the argument spec (#53106)
* Refactoring the argument spec

* Adding subarguments for recovery and acknowledge operations

* Correcting the linting errors
2019-03-01 07:38:45 -05:00
Ruben Tsirunyan 1b338f917f Fixing mediatype default value (#53114)
* Fixing mediatype default value

* Updating the documentation of media_type
2019-03-01 07:25:56 -05:00
Michael Miko 00efa26cdb Do not delete duplicate host when fetching Zabbix Hosts (#53160) 2019-03-01 09:51:39 +00:00
Shivam Singhal aa2cf46a09 Fixes typo of 'registed' to 'registered' (#52708) 2019-02-21 13:41:19 +05:30
Ruben Tsirunyan 13fa284946 zabbix_action: Adding an option for pausing operations while in maintenance (#52500)
* zabbix_action: Adding an option for pausing operations while in maintenance

* zabbix_action: Correcting linting errors
2019-02-19 03:44:00 -05:00
Pablo Piaggio d1d4f4bd27 Add support for macro contexts that have colons (#51853)
Currently when used with macro contexts that have a colon inside, 
macro_name gets truncated. A common case is contexts that represent a 
Windows drive. Examples:

  - 'C_DRIVE_THRESHOLD: "C:"'
  - 'C_DRIVE_THRESHOLD: "D:"'

This happens because line 189 assumes there are only one colon in 
macro_name, and thus two substrings to join.

To solve this, it is necessary considering that macro_name could have 
more that one colon. After the split, the first element is the proper 
Zabbix macro name. Then, the solution is joining all the remaining 
substrings after that.

This is backwards compatible in the case macro_name have only one colon.
2019-02-18 17:51:35 +00:00
Richlv 81d688a7c7 clarify how users are specified (#52260)
##### SUMMARY
Clarify that usernames - which Zabbix API documentation calls "aliases" - are to be specified for recipients

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-02-16 03:07:29 -05:00
Dag Wieers f9ab9b4d68 Assorted pylint fixes 2019-02-15 06:54:47 -08:00
Matt Clay 0a461380a3 Fix incorrect use of `is` for comparisons.
See https://bugs.python.org/issue34850 for details.
2019-02-12 16:33:13 -08:00
Jordan Borean 0f0d33a954 start getting modules to use shared import error code (#51787) 2019-02-06 12:39:17 -05:00
Richlv 901ae2333e acknowledge operations are update operations now (#51304)
Acknowledge operations are update operations since Zabbix 4.0

+label: docsite_pr
2019-01-29 09:51:18 -05:00
Richlv d2eb7a6cc1 Document trigger_severity values (#51331)
* Document the valid values for trigger_severity.
* Minor typo fix.

+label: docsite_pr
2019-01-26 07:17:39 -05:00
Dusan Matejka 2133f0821a zabbix_template: Fixed interactions between options and data within JSON object (#51222) 2019-01-26 13:15:32 +01:00
Richlv 6345ea2925 Fix example, clarify "macro_name" syntax (#51129)
* Fix the macro name in example to use allowed characters.
* Clarify on the syntax for the "macro_name" parameter.
2019-01-24 14:30:12 -06:00
Ruben Tsirunyan 18ee119a40 Adding 'eval_type' option for zabbix_action module (#51266) 2019-01-24 09:13:01 -05:00
Marcin e7b91f331b fix use_proxy option in icinga2_host (#47671) 2019-01-14 12:03:36 +01:00
Richlv 95f97bb8d6 Update zabbix_action.py (#50548)
* Update zabbix_action.py

Clarify when in/not in operators can be used.
2019-01-09 09:32:39 -06:00
mindrb 260285a73f zabbix_host_facts: get list of templates (#50007)
Get list of templates among other items. It is useful because later one can edit this list using zabbix_host module.
2019-01-09 05:12:32 -05:00
René Moser 33d888210b
zabbix: fix author's github handle (#50700) 2019-01-09 10:45:31 +01:00
Richlv c7f3829ad4 Update zabbix_action.py (#50582)
* Document "host_groups", "templates" and "inventory" operation parameters.
* Fix a couple of typos.

Fixes #50581

+label: docsite_pr
2019-01-08 10:11:48 -05:00
Richlv 9093ca1f3b Improve style and fix typos in the Zabbix module titles and descriptions (#50575) 2019-01-06 01:33:54 +01:00
Richlv ff4af614e1 Update zabbix_action.py (#50490)
* Add trailing dots for consistency.
* Document how the current host can be specified for "run_on_hosts".

+label: docsite_pr
2019-01-03 10:15:21 -05:00
Ruben Tsirunyan 09ba1f38f1 Zabbix Action: Idempotency fix (#50297) 2018-12-26 01:59:45 -05:00
Richlv 47e72063a3 Update zabbix_action.py (#50149)
Mostly typo/grammar fixes. "Zabbix Server" was changed to just "Zabbix", as it could be slightly confusing - some people might interpret this referencing the server process, although API matters. "capital-case" was changed, as it usually is one of "capital" or "upper-case".

+label: docsite_pr
2018-12-19 14:09:16 -05:00
Baptiste Mille-Mathias 8ec9565aa9 Fix typo in ds_type in examples section (#50166)
replace ds_type elasticisearch by elasticsearch
2018-12-19 13:49:06 -05:00
Dag Wieers 05c6ff79f9 Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
Toshio Kuratomi 175f3b51e5 Ensure that current uses of BaseException are required
* In some cases, it appears that Exception should have been used instead
  as there's no need to catch sys.exit KeyboardInterrupt and similar.
* In a few cases, it appears that BaseException is used because
  a library we depend on calls sys.exit() contrary to good coding
  design.  Comment those so that we know that those have been audited
  and found to be correct and change to use (Exception, SystemExit)
  instead.
2018-12-16 15:03:19 -08:00
Toshio Kuratomi 3fba006207 Update bare exceptions to specify Exception.
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
2018-12-16 15:03:19 -08:00
Johann Queuniet b079070688 Fix grafana_dashboard py2/3 compatibility (#49194)
* Fix grafana_dashboard py2 compatibility

* Convert URL output to a text/unicode string for json.loads
2018-12-12 12:42:55 -05:00
Ruben Tsirunyan d62492e656 zabbix: New zabbix_action module (#49189) 2018-12-02 10:04:45 +01:00
martinwangjian d1816d4908 grafana_datasource: Add CloudWatch as grafana datasource type (#48174) 2018-11-29 20:58:49 +01:00
Dusan Matejka a9aa1053a8 zabbix_template: fixed idempotency issues (#49188) 2018-11-29 20:38:32 +01:00
joaocpinto bbab4c1b49 Cast int for expire field to avoid call failure to sensu API (#33239) 2018-11-29 12:30:59 +00:00
Dusan Matejka 7190c73d50 zabbix_hostmacro: Fixed support for LLD type user macros and added missing validate_certs attribute (#48730) 2018-11-29 09:15:13 +01:00
Abhijeet Kasurde bc3e7bbeba
E325 Removal - Part II (#49196)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-28 13:55:52 +05:30
AlexZolotarenko 91b7bee3da -'templateLinkage' set to match Zabbix web interface defaults (#45229) 2018-11-27 09:17:05 -05:00
John R Barker 75407d3e43
Validate DOCUMENTATION.author (#48993)
* Validate DOCUMENTATION.author

Ensure that author line includes a GitHub account
2018-11-21 17:29:29 +00:00
John R Barker 8f41270a01
Bulk fix DOCUMENTATION.author (Part 3) (#48990) 2018-11-21 15:10:41 +00:00
John R Barker 97e2fa4953
Bulk module author 2 (#48955)
* Bulk fix DOCUMENTATION.author (Part 2)
2018-11-21 10:32:42 +00:00
John R Barker 3fcc564bbb
Bulk fix DOCUMENTATION.author (Part 1) (#48934)
* Bulk fix DOCUMENTATION.author
2018-11-20 19:31:35 +00:00
Pilou 7f98a8db12 BOTMETA.yml and module metadata: fix case authors (#46051)
* botmeta: fix GitHub ID case

* module authors: fix GitHub ID case

* replace CloudEngine-Ansible by submitter GitHub ID
2018-11-19 11:47:14 +00:00
Anton Alekseyev 7eebec59b3 zabbix_map: Add module to create Zabbix maps based on data written in DOT language (#23026)
* Add zabbix_map module

* Fix PEP8 complainments

* Fix dict comprehension incompatible with python 2.6

* Support Zabbix 3.4 API changes

* Fix documentation

* Minor fixes

* Move zabbix_map to zabbix namespace

* Fix compatibility issue with Zabbix >= 3.4

* Support maps and triggers as map elements
2018-11-18 15:57:51 +01:00
Tor Peeto 9d10a0e9f8 pagerduty_updates (#48367) 2018-11-14 14:47:12 +00:00
Eric Matysek 880762e07e Fix consistency issue in grafana_dashboard module. (#47459)
* Move check for 'dashboard' key to before the create/update if statement.
* Add changelog fragment for PR #47459
2018-11-09 17:27:11 -05:00
Abigail Howe e8920a8357 fix boolean logic for overwrite parameter (#47916)
* fix boolean logic for overwrite parameter

* added changelog fragment
2018-11-05 12:59:01 +00:00
Igor Simonov 8e561d1eb4 module grafana_dashboard fix for work python3 (#47708)
* fix for work python3

change string to str for work in python3

* delete unusin import module
2018-11-01 15:44:09 +10:00
Abhijeet Kasurde 3568dc512a
Misc typo fixes (#47699)
fixes requried to required

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-28 12:35:30 +05:30
Matthew Hellmer 2b52eadebb zabbix_proxy: Fixed a typo (#47698)
changed requried to required
2018-10-27 11:07:24 +05:30