- Also return url and update docs for other values to indicate they are only returned on success.
- Add integration tests
- Use info variable for common return values
- Use -1 as default status rather than None. This is lines up with with existing code in urls.py
- Add unit tests to ensure status and url are returned on failure
* netbox_device: Allow device modification
* Add ability to update and existing device
* Allow check_mode
* Fail when device name is missing
* Fail when cannot resolve ID instead of taking ID 1 by default
* netbox_device: Add diff output
* netbox: Some refactoring
* Add diff output and check_mode to netbox_ip_address
* Deduplicate redundant code into netbox_utils
* netbox_utils: A few unit tests
* Created netbox_interface module and updated netbox_utils
* Updated documentation
* Updated descriptions to include type and argument spec to include required subtions of data
* refactored to use new shared functions create()/delete()/update()
* Fixed conflicts
* Added region to API_APPS_ENDPOINTS
* Created netbox_interface module and updated netbox_utils
* Fixed PEP issues and documentation issue for ASN type
* tenant API endpoint doesn't support slug currently, changed to name, fixed user issue
* Updated documentation to include types
* Updated argument_spec to include required sub options of data
* Fixed formatting of argument spec - missing parenthesis in data options
* Fixed syntax error
* refactored to use shared functions create()/delete()/update()
* Fixed PEP issues
When haproxy is configured to track the status of a server using a
server in another backend it will not report all status as expected.
Using substring matching will solve this.
The CSV will output the server status in the following way:
MAINT: MAINT (via pxname/svname)
UP: UP
DOWN: DOWN
Haproxy doc on trach: https://cbonte.github.io/haproxy-dconv/1.8/configuration.html#5.2-track
The docs were not clear enough about what would happen if a JSON response is read.
The actual behavior is that the `json` key is always present in such cases, regardless of this parameter, so by changing a few words, we make the docs clearer to the reader.
* uri/win_uri: Make method a free text field
Since various interfaces introduce their own HTTP method (e.g. like
PROPFIND, LIST or TRACE) it's better to leave this up to the user.
* Fix HTTP method check in module_utils urls
* Add integration test for method UNKNOWN
* Clarify the change as requested during review
This PR includes:
- Adding parameter types
- Fix validate-modules issue
- Improve parameter types and resulting changes
This PR needs to be verified and tested by maintainer(s).
* Filter DNSimple request by record name.
The request was not filtered and DNSimple returns only the first 100
records so if the number of records is larger the check could fail.
This patch fixes the issue and also makes the check to perform better.
* Add changelog fragment.
* First pass at allowing unix socket with urls/uri. See #42341
* Only insert handler as needed
* Fix and add tests
* Add HTTPS functionality for unix sockets
* Additional test fixes
* Create context manager for monkey patching HTTPConnection.connect, de-dupe code, raise better errors
* doc
* Add a few more tests
* Fix __call__
* Remove unused import
* Patch HTTPConnection.connect with the functionality we want, instead of duplicating code and disabling
* Fix var name
* Remove unused var
* Add changelog fragment
* Update uri docs
* Fix rebase indentation issue
* uri: fix TypeError when file can't be saved
Fix the following exception (and others):
Traceback (most recent call last):
File "/home/lilou/debug_dir/__main__.py", line 604, in <module>
main()
File "/home/lilou/debug_dir/__main__.py", line 554, in main
write_file(module, url, dest, content, resp)
File "/home/lilou/debug_dir/__main__.py", line 320, in write_file
module.fail_json(msg="Destination dir '%s' not writable" % os.path.dirname(dest), **resp)
TypeError: fail_json() got multiple values for keyword argument 'msg'
I would rather remove **resp from returned values but this module is
flagged as stableinterface.
* Static imports are more straight forward and preferred unless dynamic inclusion is required.
* Modified description in nmcli module doc
The instructions for installing module's dependencies were incomplete.
I copied the CentOS/Fedora part from the examples section, while I figured out myself the Debian/Ubuntu package names.
+label: docsite_pr
* Fix modified description in nmcli module doc
* Fix modified description in nmcli module doc again
* Fix modified description in nmcli module doc LB
* Adapt netbox_device to pynetbox changes
Pynetbox API has changed, resulting in errors at the creation or
deletion of any device with the netbox_device modules. Fixes these
errors.
rebase
* Refactor netbox_device
Better error handling
Split the return values to `device` and `msg`, containing the created
device (if any), and the message to get more info about what has been
achieved (or the error if any)
schowave
Martin Adler
Sam Doran
Jon "The Nice Guy" Spriggs
krisvasudevan
Felix Fontein
Scott McIntyre
mttocs
John R Barker
Matt Martz
Mikhail Yohman
Bruno Inec
Sebastian Meyer
Michael Riss
Martin Krizek
Mark Zhitomirski
Taz Brown
Jonas Esbjørn Engell
Jairo Llopis
Tony Finch
Dag Wieers
Albert Cervera i Areny
Matt Clay
Jordan Borean
Pilou
Sumit Jaiswal
Marco Bellaccini
Anthony Ruhier
Abhijeet Kasurde
Jason Lingohr